Hi ther,

I did some testing with chrome, FF3 and IE7 but the ajax function breaks in IE7.

Its working good in chrome and FF3..

CommentFileSizeAuthor
#18 Picture 1.png60.83 KBnoomz

Comments

dropchew’s picture

Title: Not working in IE7 » Not working properly in IE7

Sorry let me rephrase that. I will post a screencast of it soon as I am not sure how to explain in words

Clean install on Drupal 6.8 with contri-module ajaxcomments only.

Update: screencast uploaded to http://www.youtube.com/watch?v=6-XmEg7_OcA.

skatepark123’s picture

I'm having the exact same problem with IE7, but with the 5x version of the module.

neochief’s picture

OMG, It's the strangest bug I ever seen. Yes, I can reproduce it. Will try to fix today.

bsod’s picture

same here, but happens also on FF.

netbear’s picture

Also have a problem in IE6, IE7.
The problem is such:
When clicking on the "post comment" link the page is changed, browser goes to comment/reply/nid instead of staying on the same page.
But when the "reply" link is clicked first the link "post comment" becomes ajaxy but always opens comment form not downside of the page but after the last clicked link "reply".
Tested it with two different themes and this behavior is the same in both.

MPiccinato’s picture

I am also having the same issue. Any updates?

liternet’s picture

Version: 6.x-1.x-dev » 6.x-1.6

Same here. When clicking on New Comment or Reply in IE7, the browser goes to a new page, comment/reply/nid. Using Drupal 6.9 clean install.

neochief’s picture

Status: Active » Fixed

Fixed in the latest DEV version. Please, test and tell your results. Thanks.

bsod’s picture

both issues still present for me.

neochief’s picture

bsod, I don't sure what actually do you mean. The issue is related only to IEs — when expanding comment form, textfields dissapears. This bug was fixed by me yesterday by adding hasLayout to comment form. If you see something else in FF, im pretty sure that it's other bug. Please, give me more details, or address to your test installation. At this point, I tested module with all standard themes and it works just fine.

bsod’s picture

By telling 'both' I meaned issues from comments #7 and #1. I discovered that issue from #7 is connected with clean url's - ajax comments simply don't work with clean url's turned off. Unfortunately i'm still experiencing issue showed on screencast(wrong comment form placement) also in FF and Safari(with clean drupal installation). And of course on IE. For now i'm not able to show you my site as it is on localhost, but when it will be online i'll let you know.

liternet’s picture

Version: 6.x-1.6 » 6.x-1.x-dev
Status: Fixed » Active

Well, now when I click on Post New Comment the first time, the form part flashes once, and then reappears. If I click on Post New Comment again, the form closes, and then I can never get it to open again with subsequent clicks. It only flashes, but does not stay open.

See here: http://beta.liternet.ro/node/3

liternet’s picture

bsod - February 15, 2009 - 07:22

I discovered that issue from #7 is connected with clean url's - ajax comments simply don't work with clean url's turned off.

In my case, clean url is turned on. So, the problem is not clean url being turned off.

neochief’s picture

Yes, thanks for your example, liternet. I was able to reproduce it and fixed it. Wait until new dev. will appears for download (~1 hour) and test again, it's working now (or just checkout from CVS).

neochief’s picture

Title: Not working properly in IE7 » Rendering bug in IE7
Status: Active » Fixed

As the bug with IE was fixed, I marking this issue as fixed until any other objection. Please, open another bugs if they are not related to current issue (here's first of them #376048: Not working without clean urls)

neochief’s picture

Thanks guys, finally, with MPiccinato's help I found the reason of weird behavior in FF and other browsers what you talking about. It's totally unrelated to IE, it affects any browser. The problem is described in this issue: #376040: Url analysys doesn't consider the root path. Sorry, I was not able to reproduce bug all of this time, because making all of my development on clear root path within dev. subdomains. Again, thanks, it will be fixed shortly, please track that issue for updates.

noomz’s picture

Status: Fixed » Closed (won't fix)

I have this bug with IE6. if parent block (div#comments) style is `float`, the page is sloppy. (see attachment)

The workaround for me is to add this line in ajax_comment.js line 335 (in function ajax_comments_close_form):

 $('.comment').css({'height' : '1%'});

and add in node.tpl.php

<script type='text/javascript'>
$(document).ready(function () {
  $('.comment').css({'height' : '1%'});
  $('#center').css({'height' : '1%'});  // add style to parent of comment box
});
</script>

Note that only add this style in css does not work.

noomz’s picture

StatusFileSize
new60.83 KB

Sorry, I've forgot to attach screenshot.