Should default to something and "Cancel" button

bcobin - January 7, 2009 - 16:15
Project:CCK Field Privacy
Version:6.x-1.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:obsidiandesign
Status:closed
Description

"Two for the price of one" here:

1 - The default privacy state (which I assume is "Everyone") should be indicated on the popup, don't you think?

2 - And there should be a "cancel" or "close" button - and/or you should be able to close the popup by clicking on the background, outside the box. (May find some helpful code here.)

Great concept (important, too) - with a few tweaks, this could be an "All Star!" Thanks for the fine work...

#1

obsidiandesign - January 10, 2009 - 18:17
Version:5.x-2.x-dev» 6.x-1.x-dev
Assigned to:Anonymous» obsidiandesign
Status:active» needs review

Hi bcobin,

I've attached a patch to address #2 and the popup title that you mentioned in #250873: Invalid Argument supplied for each - line 127. I modified it slightly, to 'Make field visible to:', which I think will be clearer to all users from the current 'Privacy Settings:'.

#1 is actually already done. If you set a default value on the Content field privacy settings page, the radio button will be set by default when the user clicks the padlock for the first time.

Let me know if the patch applies & does what you're looking for. I'm marking the issue to 6.x because that's where the new features/changes start, but the patch will apply to 5.x just the same.

Bryan O'Shea
Obsidian Design

AttachmentSize
cck_field_privacy.js_.355592.patch 1.18 KB

#2

obsidiandesign - August 16, 2009 - 04:29
Status:needs review» fixed

Unneeded with the inclusion of UI changes in #377950: Integration of CCK_field_privacy with user_relationship_module

#3

System Message - August 30, 2009 - 04:30
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.