there's something going on with modr8 and fivestar content. on the moder8 page in ie7 (ie6 too?), blackberry browser, and opera mini, the Save button in modr8 either does nothing or reloads the page saying "your vote has been cleared." in ff3 the moderated content is published like normal. apparently there is a problem with a conflicting binding to the Save button. im not sure if this is a moder8 or fivestar issue, but here are some links to the other issues in moder8 queue:

http://drupal.org/node/355111
approving rate-able content: Fivestar problem

http://drupal.org/node/189553
Modr8 doesn't jive with activeedit in IE6 & 7.

if this is determined not to be a fivestar problem, sorry for the post :)

CommentFileSizeAuthor
#5 nested-forms-modr8-355830-5.patch1.08 KBpwolanin

Comments

wrb123’s picture

wrb123 commented
Title: conflict with moder8 module. » conflict with modr8 module.

changed moder8 to modr8 in title :)

quicksketch’s picture

quicksketch
he/him
commented
Project: Fivestar » modr8
Version: 6.x-1.13 » 6.x-1.x-dev

It is a modr8 issue. It's caused by modr8 putting a form (Fivestar) instead of another form (the modr8 list). modr8 should either run a regex on the code to strip out the FORM tag or modr8 should separate the form entirely from the display of nodes.

pwolanin’s picture

pwolanin commented

@quicksketch - I don't quite follow the comment above - basically you're saying this is a problem due to the nesting of forms?

quicksketch’s picture

quicksketch
he/him
commented
Title: conflict with modr8 module. » Fivestar and modr8 Cause IE to Fail Moderation Form

pwolanin, Yes, if you nest <form> tags inside each other, IE (and apparently other browsers) will submit the *last* form tag they see, even if the form tag has been closed. Note that nesting form tags is also invalid HTML, so it's not really the fault of the browsers for not handling it properly.

What's happening here is modr8 wraps the entire node teaser in a form tag. However, because Fivestar places a form tag in the teaser, you end up with nested form tags. modr8 might need to take some precautions to either strip out form tags entirely from teasers, or to not wrap the node content in a form tag at all and make the form separate from the display of the teasers.

pwolanin’s picture

pwolanin commented
Status: Active » Needs review
StatusFileSize
new nested-forms-modr8-355830-5.patch1.08 KB

Ok, well sounds like a quick hack is in order to fix this in the short term, while considering something more elegant.

Can you see if this patch alleviates the problem?

wrb123’s picture

wrb123 commented

The hac... patch works! ;) with IE7 the form submission is successful and the nodes are published - I just tested it!

Notes:

Instead of showing the stars for fivestar content like before, it shows OKGoodBetterBestExcellent (or whatever the stars textual counterparts are, like that without any spaces). Not a big deal.

Instead of showing the Extra Voting Forms widget for EVF content like before, it shows text instead of the widget. Also any node which has EVF associated with it was moved over to the right (as if it were in a 2nd column on the moderated content list page). Not a big deal.

The titles of the nodes (all nodes, even those not using Fivestar or EVF) seem invisible until you mouse over them, but this could be because of the theme im using (Framework) or because of another IE problem (wouldnt be surprised). Not a big deal.

Thank you so much for releasing this patch so quickly. It will help me keep my site moving and content flowing while I am only on my phone.

-Bill

superflyman’s picture

superflyman commented

When this is fully vetted will this fix be added to version 1.1 and rereleased? Any thoughts? Looking to implement asap, just weary until this issue is resolved...

pwolanin’s picture

pwolanin commented

Since this is a pretty critical bug, I'll make a release soon- by Monday most likely

superflyman’s picture

superflyman commented

I don't mean to be a nudge. Just wondering on an ETA for this fix getting into a new build? Thanks!

wrb123’s picture

wrb123 commented

just for your information it's completely functional with the patch

pwolanin’s picture

pwolanin commented

I will roll a release today - sorry for the delay.

pwolanin’s picture

pwolanin commented
Status: Needs review » Fixed

committed the above patch to 6.x, will backport to 5.x too. Open another issue if we need further work on this.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.