This patch adds a function which makes it possible to add an existing user to an existing role.

CommentFileSizeAuthor
#1 install_profile_add_user_to_role-v2.patch826 bytesJames Andres
install_profile_add_user_to_role.patch876 bytesquicksketch

Comments

James Andres’s picture

James Andres commented
StatusFileSize
new install_profile_add_user_to_role-v2.patch826 bytes

Great patch! Seems very useful to me.

I've made a small tweak to remove the intval() lines, maybe I'm being too picky. Here's my rationale:

  • install_add_user_to_role() is an internal function only used by programmers, if they aren't passing integers .... god help us
  • If validation is required, it would be better to return FALSE or throw an error. Continuing with bad data could be very disastrous under the circumstances.
James Andres’s picture

James Andres commented
Status: Needs review » Fixed

Committed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.