coder standards fixes, extra documentation and PHP strict notice suppression
dman - January 8, 2009 - 03:22
| Project: | Rep[lacement]Tags |
| Version: | 6.x-1.x-dev |
| Component: | Code / API |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | active |
Jump to:
Description
This is all just housekeeping. No functional changes, but additional bits that makes coder.module give it a clean bill of health.
- no more PHP 'strict' notices
- added a small description to each inc file for indexing/doxygen
- added a HOOK_help() paragraph or three.
Here's the patch, but I'll CVS commit it to dev immediately, as it's safe.
It's long to look at, but that's all whitespace and comments.
| Attachment | Size |
|---|---|
| reptag-coder_help_and_notices.20090108.patch | 15.26 KB |
#1
Hi dman! Thanks for looking at the module and getting your hands dirty, I really appreciate.
The patch looks good from visual inspection, just 2 things:
1. I think the latest changes to hook_theme are not incorporated ('reptag_node_embed' is no longer required in hook_theme)
2. Its 'implementation' not 'implimentation' ;)
Otherwise feel free to commit ...
Do you think reptag is ready for a 6.x-1.0 release? I have it working on two sites and people are waiting for a tagged release long enough, I guess.
#2
'implimentation'
Man, I ALWAYS do that!
The hook_theme addition was indeed sitting around in my local patches for ages. Could have been overtaken by other changes.
I've NOT tested the new database-table-abstraction features myself. It sure looks like there's a lot of structure there for what (I thought was) a pretty straightforward task, but the roles/rights etc additions probably got pretty deep. The UI is certainly jazzed up a lot.
#3
Not sure what you are talking about ... What new abstraction features? There were no major changes to the roles/rights management as far as I remember for the 6.x version. The only additional was i18n support for all kinds of tags (including table tags) and some refactoring for utilizing the drupal_write_record() function and stuff.