Fix for various unassigned variable / undefined index errors.

We're not planning on porting uc_importer or uc_notify, so there's no need to include their files in this patch.

As a matter of consistency, I usually prefer isset() to empty(). This is partly because there are times when the data that is checked has a value of 0 or '', and that's the value that should be used rather than the default used when it is NULL. I think the only place this is actually important in this patch is in uc_product_form(), for $node->default_qty. The default value is 1, but a value of 0 is never displayed in the form, despite the fact that it is a valid value.

I cleaned up a couple of small things, just aesthetics.

Nice, but for ease of comprehension's sake, you should separate the views changes from the undefined variable changes. Put the overlapping changes into the views patch (i.e. if a variable has been created by your view patch, and you do an isset check, put it in the views patch)

One small thing too, in uc_store.module, do the if like this:

if (foo) {
}
else {
}

not like this:

if (foo) {
} else {
}

Just a consistency thing :). Thank you for your contribution(s)!

Patch for views: #367730: Views fixes

Attached the patch for variable cleanup.

I'm a little worried about the use of the static keyword in uc_product_field_enabled(). I imagine that something like SimpleTest would change the value of the variable, and then call that function again and get the wrong values. Variables are all cached anyway, so I don't think it's necessary to do it again.

There are at least 3 solutions that I can think of, but I think the best one is the easiest, which is just remove the static keyword. The rest of the function can stay the same, and so can its use in this patch.

As you have requested...

Wow. Committed this, but almost forgot to mark it fixed.

Would this patch fix:

When I try to create a view for the main page to display a image of the product, price and add to cart button I get an error on adding the image to the view:

Error: handler for node_data_field_image_cache > field_image_cache_fid doesn't exist!

All other fields work and display on the view except for the image. Any help would be great.

Adam