In style.css line 93 the following rule is definied:

ul, li.leaf {
  list-style-image: url(images/menu-leaf.gif);
}

This rule adds an unexpected (and unwanted) bullet to all unordered lists (see attached screenshot or admin/content/node or admin/user/user).
Fix for this:

li.leaf {
  list-style-image: url(images/menu-leaf.gif);
}

Stefan

Comments

stborchert’s picture

Status: Active » Needs review

Of course that patch needs review :-)

Status: Needs review » Needs work

The last submitted patch failed testing.

stborchert’s picture

Status: Needs work » Needs review
StatusFileSize
new732 bytes

Converted line endings to LF (UNIX).

sivaji_ganesh_jojodae’s picture

it works :D

catch’s picture

Status: Needs review » Needs work

Shouldn't this be

ul li.leaf
Otherwise it could apply to ol too right?

stborchert’s picture

StatusFileSize
new782 bytes

Yes, you're right.
Changed the rule to ul li.leaf.

stborchert’s picture

Status: Needs work » Needs review

patch needs review of course.

Status: Needs review » Needs work

The last submitted patch failed testing.

stborchert’s picture

Huh? "Translation import" fails because of a CSS rule? Maybe a problem with the test bot (another patch of mine faild with the same result)?

stborchert’s picture

Status: Needs work » Needs review

Same patch (retry). I don't think a css rule let a translation import fail. Tests passes on to different servers of mine.

Status: Needs review » Needs work

The last submitted patch failed testing.

stborchert’s picture

Status: Needs work » Needs review

retest

johnalbin’s picture

Status: Needs review » Needs work
Issue tags: +CSS, +theme

Garland, by design, wants to style all its UL lists in this way. So ul, li.leaf is the proper ruleset to accomplish that.

I think the patch in #4 of #394670: Bullet on UL lists showing up incorrectly is the correct approach.

johnalbin’s picture

Title: false style rule for unordered lists » bullets appearing on UL lists with list-style-type: none
stborchert’s picture

Status: Needs work » Needs review
StatusFileSize
new1.34 KB

This is the patch created by momendo with a small addition (user-admin-filter was missing).

johnalbin’s picture

Component: Garland theme » drupal.css
Status: Needs review » Closed (duplicate)

The patch looks good.

But it looks like the real problem was that those forms were incorrectly adding leaf class to those list items. I no longer see the problem in Drupal 6.11 which means it was fixed elsewhere. Unfortunately, I can't find the issue where it was fixed or I would link to it.

stborchert’s picture

Status: Closed (duplicate) » Needs review

Issue is still valid (setting both issues to duplicate didn't fix it :-) ).

Status: Needs review » Needs work

The last submitted patch failed testing.

stborchert’s picture

Status: Needs work » Needs review

Dear bot. I'm sorry but I didn't trust you :-) Please re-test it.

eigentor’s picture

Status: Needs review » Reviewed & tested by the community

This works.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

OMG! This has been annoying me forever. Thanks so much!

Committed to HEAD.

eigentor’s picture

A giant beer to stBorchert. Even with having set this to RTBC (was there bribing involved?) I only now fully realize that it annoyed me forever, too.

Status: Fixed » Closed (fixed)
Issue tags: -CSS, -theme

Automatically closed -- issue fixed for 2 weeks with no activity.