Closed (outdated)
Project:
Token Filter
Version:
6.x-1.x-dev
Component:
User interface
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
8 Jan 2009 at 22:08 UTC
Updated:
24 Mar 2018 at 06:13 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
lee20 commentedJust an FYI, this patch will work with Drupal 6 along with the tiny patch found here: http://drupal.org/node/356168
Comment #2
eojthebravePatch works as stated. Though you might want to mention that this patch also addresses some white space issues in the existing code.
Also, it would probably be a good idea to limit the list of available tokens on the filter tips help page to just global and user since those are the only ones that currently work with the module. Marking as needs work as this is probably something that should get done before adding this code to the module.
Comment #3
pvhee commentedCould this patch be recreated against the 6.x-1.x-dev version? Note that issues with white spaces have been fixed already in that version, and it now accepts also all kinds of token contexts (not just global and user).
Comment #4
trouble.tribbles commentedIs there a recent version of this?
Comment #5
joachim commentedMissing filter tips is a bug...
Here's a patch for D6. No need for a patch for 7; it's fixed in that version.
Few changes from the above patch:
- I don't see a need for a theme function here. Core hook_filter_tips() don't theme this output, apart from things like theme_table().
- the patch has tons of extra changes which aren't related to this issue
- there's no need for our own link to filter/tips, the link is shown at the bottom of the short tips already.
- it's best to include variables in a t() rather than concatenate them
- this module doesn't allow prefix and suffix to be customized AFAICT, so I've hardcoded the initial [token and closing ].
Comment #6
darvanenDrupal 6 version is no longer supported. Please reopen this if you find it is relevant to Drupal 7 or 8.