Posted by lee20 on January 8, 2009 at 10:08pm
5 followers
| Project: | Token Filter |
| Version: | 6.x-1.x-dev |
| Component: | User interface |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs review |
Issue Summary
Here is a patch that adds filter tips to the Input format help with a link to the full list of available tokens.
| Attachment | Size |
|---|---|
| token_filter.module.patch | 3.48 KB |
Comments
#1
Just an FYI, this patch will work with Drupal 6 along with the tiny patch found here: http://drupal.org/node/356168
#2
Patch works as stated. Though you might want to mention that this patch also addresses some white space issues in the existing code.
Also, it would probably be a good idea to limit the list of available tokens on the filter tips help page to just global and user since those are the only ones that currently work with the module. Marking as needs work as this is probably something that should get done before adding this code to the module.
#3
Could this patch be recreated against the 6.x-1.x-dev version? Note that issues with white spaces have been fixed already in that version, and it now accepts also all kinds of token contexts (not just global and user).
#4
Is there a recent version of this?
#5
Missing filter tips is a bug...
Here's a patch for D6. No need for a patch for 7; it's fixed in that version.
Few changes from the above patch:
- I don't see a need for a theme function here. Core hook_filter_tips() don't theme this output, apart from things like theme_table().
- the patch has tons of extra changes which aren't related to this issue
- there's no need for our own link to filter/tips, the link is shown at the bottom of the short tips already.
- it's best to include variables in a t() rather than concatenate them
- this module doesn't allow prefix and suffix to be customized AFAICT, so I've hardcoded the initial [token and closing ].