Closed (fixed)
Project:
Views Bulk Operations (VBO)
Version:
7.x-3.x-dev
Component:
User interface
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
9 Jan 2009 at 06:14 UTC
Updated:
7 Jul 2011 at 22:51 UTC
Jump to comment: Most recent file
Comments
Comment #1
dwwLooking briefly at the code, it seems pretty straight forward inside views_bulk_operations.module itself. Instead of testing
$plugin->options['skip_confirmation'], we could be testing something like$plugin->options['skip_confirmation'][$operation].The bigger question appears to be the UI for the views style plugin. Seems like we need a table instead of the current pile of checkboxes and operations. I'm trying to figure out how easy that is from merlinofchaos in IRC right now. ;) Not trivial. For an initial attempt, this just duplicates the operations with another set of checkboxes to control the confirm form. I know it's lame, but I'm just getting it started.
Another tricky part is the upgrade path, since existing views will have an integer saved for this option, instead of an array. This patch completely ignores this problem.
Otherwise, it works fine -- it's just ugly and doesn't handle existing views that think skip_operation is an int, not an array.
Comment #2
infojunkieThanks for the initiative. I haven't looked at the patch yet, but it seems that what you achieved is to specify the confirmation *per operation per view*, not just per operation. If you wanted to do the latter, you would expose a general VBO config screen in the Drupal admin section, in which you would ask which operations need confirmation. Which one makes more sense in your usage scenario?
Comment #3
dwwOh interesting. I hadn't thought of doing a site-wide setting to globally specify confirmation for each operation. I suppose that any operation that's "destructive" and would often want a confirmation step would probably always want it. However, that would introduce a lot of site-wide variables, which are more expensive overall for the site than these per-view settings which are only loaded with the view when needed, instead of on every page no matter what. Also, I could dream up use-cases where you'd want confirmation on an operation in some cases but not others. For example, what about an "expert mode" admin view somewhere that assumes you know what you're doing, vs. the standard admin view that people get by default.
So, I think it'd probably make sense to just continue down the current path and see how nasty the theme function stuff to get the UI better is. If it's a huge can of worms, we can reconsider, but since the actual functionality now works in the more fine-grained approach, we might as well keep it. ;)
That said, I'll certainly defer to the community -- we should probably get some other VBO users/developers to weigh in here.
Thanks!
-Derek
Comment #4
infojunkieComment #5
jjwhitney commentedI've updated this patch to work with the latest VBO source.
Comment #6
infojunkieThanks for the updated patch.
I used this opportunity to make a major settings UI update. Please try it and let me know!
Comment #7
jjwhitney commentedI had a little trouble at first after updating, because my view wasn't showing any records, but clearing the cache did the trick.
It works great now! Thanks!
Comment #8
jjwhitney commentedHmmm... I still have one little problem: For single actions using "Merge single action's form with node selection view", the "Skip confirmation step" checkbox has no effect.
Comment #9
bojanz commentedAlso, this needs to be ported into 7.x-3.x.
Comment #10
bojanz commentedLet's use this issue for tracking the port and handle any bugs in new issues.
Comment #11
infojunkie@jjwhitney, can't reproduce your scenario with single action and merging action form into node selection.
Comment #12
bojanz commentedDone.