Closed (fixed)
Project:
Audio
Version:
6.x-1.x-dev
Component:
Miscellaneous
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
9 Jan 2009 at 10:38 UTC
Updated:
28 May 2009 at 16:00 UTC
Jump to comment: Most recent file
Comments
Comment #1
roger6106 commentedI am also unable to add new categories.
Comment #2
deviantintegral commentedI encountered this as well. It looks to be caused by the fact that the system settings form is used, without using the existing submit and theme function. You can't just add the submit function, as it will later in the process overwrite the variable with the invalid data.
I also had to array_filter() rows as it was creating an array of empty arrays which caused an extra "ghost" table to appear.
This patch solves the issue for me.
Comment #3
roger6106 commentedThis patch allows me to add and remove tags, although it gives me an error when submitted:
warning: Invalid argument supplied for foreach() in [...]/sites/all/modules/audio/audio.admin.inc on line 149.
Comment #4
roger6106 commentedI did some more testing with this patch, and I realized that deleting metadata wasn't working. I updated the patch submitted by deviantintegral to allow for the deleting of metadata. This also gets rid of the error I was experiencing.
Comment #5
wedge commentedI had the same problem but forgot to check for existing solutions before trying to fix it myself.
Hence, my fix is almost the same as yours. :)
Comment #6
drewish commentedboy i love it when i half port something... at least there was a TODO.
wedge's patch looks pretty good but i wonder if we need to combine in the last bit of roger6106's that hits the theme function? it seems like wedge's might handle it all. i don't have time to test it right now but i'm going to try to clean up the audio module queue later this week.
Comment #7
deviantintegral commented@drewish, I'm pretty sure the patch in #5 won't display the table properly. I'm not sure why it should call theme_system_settings_form() if it's not a system settings form. Some hybrid of #4 and #5 sounds good to me.
Comment #8
drewish commentedcommitted the attached. it also adds drag and drop ordering to the table.
Comment #9
deviantintegral commentedTabledrag - sweet! Thanks for getting this in.
Comment #10
drewish commenteddeviantintegral, of course, sorry it's taken so long. i really appreciate all your patches it makes it a lot easier to get started on these bugs.