Closed (duplicate)
Project:
Drupal core
Version:
7.x-dev
Component:
node.module
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
9 Jan 2009 at 10:45 UTC
Updated:
26 Nov 2010 at 21:36 UTC
Jump to comment: Most recent file
Comments
Comment #1
dawehnerthis is a very strange issue
i have written this into nodetpl
And "add new comment" is displayed in messages but it is not printed on the page, what a issue
Comment #2
dawehnerthis is css issue,
because the html is generated
but the margin in
#comments {style.css?F (Linie 707)of garland hides the linkthis patch fixes the issue, but i don't know wether this has issues on other stuff (css i not my world)
Comment #4
catchThat fail can't be valid.
Comment #5
dawehnerheheh thats true,
perhaps the " " was removed in node.tpl.php?
Comment #7
dawehnerComment #8
cburschkaTestbot is right. Patch erroneously includes a whitespace fix to node.tpl.php that has been committed by now (I get asked if I want to reverse the patch).
That should never have been in here in the first place, as the patch isn't concerned with node.tpl.php at all. It's best to avoid this by cleaning your local CVS copy out regularly, or diffing only the file you want to submit a change for. :)
Comment #9
dawehnermh strange i do cvs update -C quite often
here is a rerole
Comment #10
xmacinfoWhich patch is better?
You patch or this patch: #438224: "Post comments without approval" permission name is completely misleading --> at #4. ;-)
Comment #11
cburschkaAre the top and bottom margins something other than 0 by default, so that they need to be overridden?
If they are not, then I would suggest using "margin-right: -25px" which is easier to read.
Comment #12
netsensei commentedHehe, there you touched the sensitive 'px vs em' topic. :-)
I respected the em unit in my patch to make sure the relative spacing above and below would be respected over different resolutions, font sizes, etc. I wouldn't change this to px.
Comment #13
jpoesen commentedDuplicate of #371649: Link to "Add new comment" disappears once first comment is entered with same solution.
Comment #32
silverwing commentedClosing comments (spam)