split mode

Is this against 4.6.3 or HEAD?, as the issue version says 4.6.3 but the patches are for HEAD.

Anyways, in trying it against HEAD, patch #8 applies and split.php #6 executes OK.

Came across 3 problems so far:
- In admin/logs, admin/path and admin/user I get: Warning: preg_replace_callback() requires argument 2, '_unicode_caseflip', to be a valid callback in \files\split\dr\drupal_strtoupper.inc on line 8

- In admin/filters/add I get: Warning: uasort(): Invalid comparison function. in \files\split\fi\filter_list_all.inc
(I think some of the split functions are not finding they callbacks)

- Apache PHP module crashes when I try to create content eg node/add/page. I don't get a entry in apache's error.log, but the last file read before the crash is: \files\split\me\menu_parent_options.inc

Everything else I tried seemed to work OK, haven't looked at the code yet.

Test enviroment is: Apache 1.3.33/PHP 4.4.0 under windows with current HEAD

Looking at pacth #8 (not trying it, just examining the diff), my only suspicious part is the system module change. Why does that add a function_exists(), while all other parts remove these and add module_exists() and module_invoke()?

The patch looks good

I ran some quick tests, benchmarked the index.php page of a default drupal install. Using split mode was almost twice as fast as without. I did the same after I enabled all core modules, this time it was more than five times as fast. Of course this was a special situation; no opcode cache and a very simple page, but it shows some promising results.

I still encountered a few problems though:
- after changing the site status to offline, users get
Fatal error: Call to undefined function: drupal_site_offline() in /home/jabart/public_html/drupal/index.php on line 24

- on q=admin/comment/configure:
warning: array_filter(): An error occurred while invoking the filter callback in /home/jabart/public_html/drupal/files/split/el/element_children.inc on line 2.

warning: implode(): Bad arguments. in /home/jabart/public_html/drupal/files/split/fo/form_get_error.inc on line 7.

A big +1 for this feature, for the reasons highlighted here:
http://drupal.org/node/32262#comment-53036

+1 for compatability so far. I haven't looked closely at the memory aspect of it, but installed it on a stock 4.7 and have been poking around the system. No problems.

Hi chx,
I am facing the drupal memory exausted problem. since I am on a shared server and cannot be allocated more than 16M of memory, this patch looked interesting. currently I am 4.6.4, is there a consise HOWTO on the steps needed to install this patch. do I have to do anything with my php installation etc., or will it work on the same PHP5 installation.

It is still a feature. :)

+1

I rerolled the patch.

A few hunks failed.

In particular, I couldn't replace the following code, because apparently the whole block has disappeared.

<code>*** 571,577 ****

    if (!isset($title)) {
      // during a bootstrap, menu.inc is not included and thus we cannot provide a title
-     if (function_exists('menu_get_active_title')) {
        $title = check_plain(menu_get_active_title());
      }
    }
--- 576,582 ----

    if (!isset($title)) {
      // during a bootstrap, menu.inc is not included and thus we cannot provide a title
+     if (!drupal_bootstrap()) {
        $title = check_plain(menu_get_active_title());
      }
    }

But I think it would work as well as the previous patch.

Well, it's probably out of sync again.

chx: Is this patch implemented?

Moving to cvs.

Hasn't this been superceded by the Registry?

#221964: Registry

This has been superseded by the D6 page split and the D7 Registry.