Fix hidden module dependencies

chx - January 9, 2009 - 23:58
Project:Drupal
Version:7.x-dev
Component:base system
Category:bug report
Priority:minor
Assigned:chx
Status:closed
Description

fix taxonomy test dependency

AttachmentSizeStatusTest resultOperations
taxo_test_depends.patch362 bytesIdleFailed: 8504 passes, 0 fails, 44 exceptionsView details

#1

chx - January 10, 2009 - 00:02

#2

System Message - January 10, 2009 - 00:45
Status:reviewed & tested by the community» needs work

The last submitted patch failed testing.

#3

webchick - January 10, 2009 - 05:39

I have no idea WHY, but I can reproduce the results of the testing bot locally. Needs work.

#4

chx - January 10, 2009 - 10:36
Status:needs work» needs review

We unset the hidden modules from $files so that when a hidden module depends on them then it breaks. Fixed.

AttachmentSizeStatusTest resultOperations
taxo_test_depends.patch1.77 KBIdlePassed: 8866 passes, 0 fails, 0 exceptionsView details

#5

Damien Tournoud - January 10, 2009 - 10:47

Interesting. May be we should unset the hidden module latter in the process then?

#6

Damien Tournoud - January 10, 2009 - 10:53

#7

catch - January 10, 2009 - 11:14
Title:fix taxonomy test dependency» Fix hidden module dependencies

In this particular case, we should move the entire test case from taxonomy_test.test to taxonomy.test anyway - only the module needs to be there to implement the hooks, not the test itself - been meaning to do that for ages. So re-titling, and I'll open a cut and paste issue to move the test across later on.

#8

chx - January 10, 2009 - 15:07

Damien, no because if you move the unset then here you need to check for hidden-ness and at other places too.

#9

Damien Tournoud - January 10, 2009 - 15:09
Status:needs review» reviewed & tested by the community

Ok, makes sense.

#10

Dries - January 11, 2009 - 07:49
Status:reviewed & tested by the community» fixed

Committed to CVS HEAD. Thanks!

#11

System Message - January 25, 2009 - 07:50
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.