Posted by chx on January 9, 2009 at 11:58pm
| Project: | Drupal core |
| Version: | 7.x-dev |
| Component: | base system |
| Category: | bug report |
| Priority: | minor |
| Assigned: | chx |
| Status: | closed (fixed) |
Issue Summary
fix taxonomy test dependency
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| taxo_test_depends.patch | 362 bytes | Idle | Failed: 8504 passes, 0 fails, 44 exceptions | View details |
Comments
#1
#2
The last submitted patch failed testing.
#3
I have no idea WHY, but I can reproduce the results of the testing bot locally. Needs work.
#4
We unset the hidden modules from $files so that when a hidden module depends on them then it breaks. Fixed.
#5
Interesting. May be we should unset the hidden module latter in the process then?
#6
#7
In this particular case, we should move the entire test case from taxonomy_test.test to taxonomy.test anyway - only the module needs to be there to implement the hooks, not the test itself - been meaning to do that for ages. So re-titling, and I'll open a cut and paste issue to move the test across later on.
#8
Damien, no because if you move the unset then here you need to check for hidden-ness and at other places too.
#9
Ok, makes sense.
#10
Committed to CVS HEAD. Thanks!
#11
Automatically closed -- issue fixed for two weeks with no activity.