fix taxonomy test dependency

CommentFileSizeAuthor
#4 taxo_test_depends.patch1.77 KBchx
taxo_test_depends.patch362 byteschx

Comments

chx’s picture

chx commented
Issue tags: +Quick fix

Status: Reviewed & tested by the community » Needs work

The last submitted patch failed testing.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

I have no idea WHY, but I can reproduce the results of the testing bot locally. Needs work.

chx’s picture

chx commented
Status: Needs work » Needs review
StatusFileSize
new taxo_test_depends.patch1.77 KB

We unset the hidden modules from $files so that when a hidden module depends on them then it breaks. Fixed.

damien tournoud’s picture

damien tournoud commented

Interesting. May be we should unset the hidden module latter in the process then?

damien tournoud’s picture

damien tournoud commented
Issue tags: -Quick fix
catch’s picture

catch
he/him
Primary language English
commented
Title: fix taxonomy test dependency » Fix hidden module dependencies

In this particular case, we should move the entire test case from taxonomy_test.test to taxonomy.test anyway - only the module needs to be there to implement the hooks, not the test itself - been meaning to do that for ages. So re-titling, and I'll open a cut and paste issue to move the test across later on.

chx’s picture

chx commented

Damien, no because if you move the unset then here you need to check for hidden-ness and at other places too.

damien tournoud’s picture

damien tournoud commented
Status: Needs review » Reviewed & tested by the community

Ok, makes sense.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.