Faulty Drupal.gaTrackerAttach init prevents click tracking (with jquery_update only)

See http://drupal.org/node/342663#comment-1139795 for a workaround.

Make sure you have downloads, email and/or outgoing links tracking enabled. Aside it may take some time after the first event is recorded and until it's shown in the reports... I cannot say how long this might take... try to wait up to 2 weeks.

Hm... checked your http://www.toodlepip.co.uk site and code is correct... all should work, but I also don't see the Event is firing the tracking out to google if a external link is clicked... I have not tested this with jquery_update... but I'm not aware about jquery functions that have changed. Are you able to test with standard jquery? Could you try to add some console.log() lines to the googleanalytics.js and debug if it jumps in the correct if statement?

Ok, this is good and helpful information.

I need to investigate why this break things, but you can keep it as is now as an interims solution until we found the source of this issue and a fix. No functional problem at all - the context is not really used yet.

I'm moving this to jquery_update for now. Maybe someone from there can help us quickly or at least give a hint what could be broken and how to fix if not a bug in jquery_update.

Marked #368351: Can't get "Track outgoing links" functionality to work as a duplicate.

I just got to this issue after experiencing this behavior. One strange thing is that I have several drupal sites, all with jquery_update and the latest jquery and all of them are working except one, this one.

Now I am not sure the bug goes through jquery_update, can you explain me what context is and how that should be used?

What I can tell is that in the site not working the line:

context = context || document;

Is returning context and then it's not working. If I make that to be just

context = document;

It starts working, which is the same as doing

$('a').click( function() {

as explained in #7,

but if context is not used, and it's making problems, isn't it better to remove it from the google analytics code?

a.=

I have just checked the sites that are working and they have an older version of the GA code without the context whatsoever, just as #7. What is this? and is it correctly used?

D6 have added context = context || document; in drupal.js.

Drupal.attachBehaviors = function(context) {
  context = context || document;
  if (Drupal.jsEnabled) {
    // Execute all of them.
    jQuery.each(Drupal.behaviors, function() {
      this(context);
    });
  }
};

I've backported this logic to D5 to make the code easier to maintain. See #330616: Allow re-binding click events with AHAH/AJAX why context have been added. I wonder why it is not working on one of your sites, but the others... very strange...

Could one of you with the jquery_update installed give this code change together with $('a', context).click( function() { a try?

[googleanalytics.js]

if (Drupal.jsEnabled) {
-  $(document).ready(gaTrackerAttach);
+  $(document).ready(function() {
+    Drupal.gaTrackerAttach(null);
+  });
}

subscribe

Above code in #17 has a bug. Please give this new code a try. I think it should work now.

[googleanalytics.js]

if (Drupal.jsEnabled) {
  $(document).ready(function() {
    Drupal.gaTrackerAttach(this);
  });
}

I tested the changes above on my live site with original jquery and jquery_update and clicks on outgoing links are working for me. I've committed the code to CVS, but I would be happy to get some feedback from you guys if it would also work for you before rolling a new release.

It's very simple to test if you create links with target _blank as it would help you to see that the executed GA request is shown in Firebug pane on the page where you clicked the link. Otherwise you need Firebug history add-on or Fiddler to see the request.

i open an issue : http://drupal.org/node/846344 for the 6.x version