Hi Stella,

On one of my websites I have enabled lightbox for the login box. After I upgraded to the new version (5.x-2.9), if the user makes a mistake with the login username/pass, s/he is redirected to the URL /user/login/lightbox2?destination= which is not picked up by Lightbox and only the unstyled HTML of the box is displayed.

Is this a problem in my configuration or it is a Lightbox2 issue?

Thanks in advance!

Tisho

CommentFileSizeAuthor
#9 lightbox2-356834-d5.patch2.65 KBgnat
#8 lightbox2-356834-d6.patch2.81 KBgnat
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

wmnnd’s picture

wmnnd CreditAttribution: wmnnd commented

I have the very same problem with the current D6 version.

hankpalan.com’s picture

hankpalan.com CreditAttribution: hankpalan.com commented

Having same issue.

elanghout’s picture

elanghout CreditAttribution: elanghout commented

Same issue here. In version 6.x-1.9 and the v6.x DEV from feb 9.

floris-1’s picture

floris-1 CreditAttribution: floris-1 commented

anyone figured this out ?

i seem to have the same problem, havent found a solution just yet

floris-1’s picture

floris-1 CreditAttribution: floris-1 commented
Version: 5.x-2.9 » 6.x-1.9
Component: User interface » Code
wmnnd’s picture

wmnnd CreditAttribution: wmnnd commented

Will this be fixed?

stella’s picture

stella CreditAttribution: stella commented

eventually - just rather busy at the moment. If you feel like investigating it yourself and creating a patch, then it's more likely to get done quicker.

Cheers,
Stella

gnat’s picture

gnat CreditAttribution: gnat commented
FileSize
lightbox2-356834-d6.patch2.81 KB

This bug is caused by the fact that lightbox2 prints the login form directly to get a clean version used in the pop-up. The problem is, that when you get a failed form validation, like a bad password, the form gets printed cleanly, and you miss out on the drupal_set_message() letting you know about the error. Since Drupal spools those messages until the next usable page, you will see it when you go back to a fully rendered page.

This patch solves the problem by only printing a clean form if there is no POST information. This allows successful logins to proceed as normal, and failed logins to occur on the standard Drupal generated login page, with errors noted and flagged.

This is for the D6 version.

gnat’s picture

gnat CreditAttribution: gnat commented
FileSize
lightbox2-356834-d5.patch2.65 KB

And the D5 version.

gnat’s picture

gnat CreditAttribution: gnat commented
Status: Active » Needs review
wmnnd’s picture

wmnnd CreditAttribution: wmnnd commented
Status: Needs review » Reviewed & tested by the community

The patch works great, thank you very much.

marcvangend’s picture

marcvangend
he/him
Primary language Dutch
Location Amsterdam
CreditAttribution: marcvangend commented

The patch works, but it's not the most beautiful method. Am I asking too much when I say: Can't I go back to the same page with a lightbox over it?

stella’s picture

stella CreditAttribution: stella commented
Status: Reviewed & tested by the community » Fixed

Committed, thanks!! The fix will be included in the next dev release of the module later today.

Cheers,
Stella

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

csc4’s picture

csc4 CreditAttribution: csc4 commented
Version: 6.x-1.9 » 6.x-1.x-dev
Status: Closed (fixed) » Active

Sorry for reopening this - but I have the latest dev version with this patch installed and I'm getting redirected on a successful login to user/login/lightbox2 which is throwing an access denied error.

redijedi’s picture

redijedi CreditAttribution: redijedi commented

subscribing

NickTech’s picture

NickTech CreditAttribution: NickTech commented

subscribing

SeanBannister’s picture

SeanBannister CreditAttribution: SeanBannister commented

I'm running the current dev and it's working great, no errors.

stella’s picture

stella CreditAttribution: stella commented

@csc4 : are you logging in via the login block, the full login page, or something else?

stella’s picture

stella CreditAttribution: stella commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

vardas’s picture

vardas CreditAttribution: vardas commented
Title: Introduced bug in Lightbox2 login? » Using Lightbox2 to show Login
Category: bug » support

Can anyone point me at the documentation that describes how to enable Lightbox2 for login. I have searched but can't find any mention of how to do this.

marcvangend’s picture

marcvangend
he/him
Primary language Dutch
Location Amsterdam
CreditAttribution: marcvangend commented
Title: Using Lightbox2 to show Login » Introduced bug in Lightbox2 login?
Category: support » bug

Please don't hijack other issues for support questions, but open a new one instead.

dorijrs’s picture

dorijrs CreditAttribution: dorijrs commented

how do i apply that patch into the lightbox 2 module?

rpataca’s picture

rpataca CreditAttribution: rpataca commented
Version: 6.x-1.x-dev » 7.x-1.0-beta1

This still appears to be an issue in D7???