Hiya,

Just noticed this annoying little bug with the customerror.module (using Drupal 4.6.3)

Using customerror.module

1. user (not logged in) selects a link that requires login e.g. /profile
2. user triggers a 403 error and is redirected to customerror page
3. user logs in
4. user gets the access denied page again.

Without using customerror module

1. user (not logged in) selects a link that requires login e.g. /profile
2. user triggers a 403 error and gets the default Access denied message
3. user logs in
4. site displays the /profile page properly.

Have spotted a few posts mentioning similar errors that links to patches for the common.inc file, although they are for previous versions of Drupal and the current common.inc remember-and-redirect-after-login works without customerror.module.

just thought I'd flag it.

Dub

Comments

xe’s picture

xe commented

same here
it would be nice to redirect the user to the front page once logged in.
otherwise they still see the access denied page, they will think their login did work, when actually they had to click on Home to see the content.

kbahey’s picture

kbahey commented

Dub

I think we had a discussion some time back on how to redirect. I can't seem to find the issue though.

If there is a solution to this, I would like to include it.

kurkuma’s picture

kurkuma commented

Same problem here. More than anoying is critical for the acceptance and use of this module.

kbahey’s picture

kbahey commented
Assigned: Unassigned » kbahey
Status: Active » Fixed

After some thought (ha!), I found a solution to this issue.

The downside is that it requires a change to common.inc. The good news is that it is only one line.

I updated the INSTALL.txt document to include details on how to make that change.

Tobias Maier’s picture

Tobias Maier commented

kbahey: is it possible to commit this changes to head?
or are there some downsides of this patch?

kbahey’s picture

kbahey commented

Tobias

I have added a patches directory for customerror. In it, there are patches for HEAD (4.7) and 4.6.3, as well as a prepatched version of common.inc.

This way, anyone who installs the customerror module can take advantage of this new feature.

I use it on my sites and it is quite handy.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)

  • Commit d755423 on 4.6.x-1.x, 4.7.x-1.x, 5.x-1.x, 6.x-1.x, master, 8.x-1.x by kbahey: 
    #35687 access denied page appears after user logs in Now redirects user...