The module settings form would benefit from some corrections and improvements:

  • Check-box labels which read "Unregistered Nodes" and "Unpublished Users" - these are mixed up and don't make sense. They should of course read "Unregistered Users" and "Unpublished Nodes" .
  • "Show Sice Counter Since" should probably read "Show Site Counter Since".
  • The link to the Site Counter Report page is duplicated, appearing in both the basic and advanced fieldsets. It would be better if it appeared as help text at the start of the page, outside of the fieldsets.

Also, I suggest changing the module package to "Statistics". At the moment it appears in a group called "Easy Module" which doesn't really give us any clue about the module's purpose. The "Statistics" package is already being used by the Statistics Filter module, and it would make sense to group these together, I think.

Here's a patch which makes all of these changes against version 6.x-1.5

CommentFileSizeAuthor
admin_ui_improvements.patch12.84 KBandrewmacpherson

Comments

danielb’s picture

danielb commented

I agree about these, except that the Unregistered Users is actually a statistic about Inactive Users if you check the code. See http://drupal.org/node/387378

drupalnesia’s picture

drupalnesia commented

Counter 6.x-2.0 includes these bug fix:
Bug fix: many miss-type corrected by andrewmacpherson (http://drupal.org/user/265648)
Bug fix: rename package name from "Easy Module" to "Statistics" by andrewmacpherson
Bug fix: remove duplicate link of Site Counter Report by andrewmacpherson
Bug fix: unregistered users rule by danielb (http://drupal.org/user/134005)

Will be release soon, thanks for bug report.

drupalnesia’s picture

drupalnesia commented
Status: Needs review » Closed (fixed)

Counter 6.x-2.0 available now!
Please create new forum thread for bug reporting or feature request.

Thanks to all contributions to this module.