Replace jquery_interface with jquery_ui
Pierre_M - January 11, 2009 - 19:50
| Project: | Todolist |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | marvil07 |
| Status: | closed |
| Issue tags: | jQuery |
Jump to:
Description
Hi, I got todolist installed, but I'm getting an error when I try to view the todolist full node view. Here is the error /sites/all/modules/todolist/todolist.module on line 128. I deleted line 128 jquery_interface_add(); now I can see the add task button without the error, but after submitting a task I get white screen.
The drupal6 version was posted on the 10th, I'm not sure if it hasn't been entirely ported to drupal6 or some step I'm missing. If needed I'm willing to help a bit with this module, not very good coding modules but you if guys need my help...
Pierre
#1
Yeah, it's in process now.
I really apreciate testing :D
#2
I've got jquery_ui, but it still there is white screen during task adding.
#3
hey you can copy code from list module we have already ported it to use jquery_ui :)
http://drupal.org/project/list
regards
sumitk
http://sumitk.net
#4
Hi sumitk,
Where could I find the code for the list project?... ok scrap that, moment of stupidity. checked the cvs :)
Thanks,
Peter
#5
@ #2
Because there is a if condition in the code that is checking for an input named 'sort' but it doesn't exist!
Have a look in the function 'todolist_create_task()'.
A security issue: $_REQUEST should be replaced by $_POST
#6
Can you explain the fix in more detail for non-programmers to fix?
#7
What needs to happen here, and how can we help?
#8
Hi jeffschuler,
Like it's mentioned, the problem here is that we¡re not using jquery_ui, so patches are _really_ welcome. Take a look to the list project too.
Sorry for log delay here, but I have not so many time now.
So, like I said, patchers are really welcome :D
@palo.. it's a code issue :(
#9
So, if I (following what s8inac said in #5) -- set
$_REQUEST['sort'] = 0;in
todolist_create_task()... I don't get a white screen anymore, but, rather, just see the Javascript from that function printed on the page, by itself.I'm not familiar with what
todolist_ok_js()does, in setting new content headers and sprinkling Javascript in with the PHP.How is this supposed to work to inject the js into the loaded page? Is there some prerequisite I'm missing?
#10
subscribing
#11
this is a simple fix change line 128 that says
jquery_interface_add();to
jquery_ui_add();(this)
is just part of the fix sorry
JOsh
#12
@sanguis: exactlly, that's part of the fix. Thanks for the help.
There's still a lot to do here :(
#13
finally, reviewing list module, I arrive to a beta-1, where jquery_ui is used :D
http://drupal.org/cvs?commit=272424
#14
Automatically closed -- issue fixed for 2 weeks with no activity.