node_gallery.pot - Translation template for module

Comments

azovsky’s picture

nancydru’s picture

Status: Postponed (maintainer needs more info) » Needs review
dddave’s picture

Version: 6.x-1.0-alpha3 » 6.x-2.x-dev
Component: Code » User interface
Category: support » task
Status: Needs review » Active

I guess we need this for proper i18n of this module. So if anybody wants to tackle this - please do it. Can some stuff of #1 be used? Or is this already in 2x?

dddave’s picture

Status: Active » Needs review

Could need some advise from the maintainers on this.

Also: Is there some resource how to provide a translation? Would like to help with German stuff.

nancydru’s picture

It's pretty simple. Install the Translation Template Extractor module and run it, saving the output into the "translations" (D6) directory.

kmonty’s picture

Status: Needs review » Needs work

This clearly is out of date.

dddave’s picture

I can provide the german translation. That said, I think we should wait until there is some kind of string freeze, probably until release candidate status.

Currently #612122: node_gallery_access doesn't let users with 'access protected contents' or 'edit protected contents' view password galleries is going to make string changes.

dddave’s picture

I just for fun gave it a run with Translation Template Extractor and received a bunch of ugly red messages:


    * The first two watchdog() parameters should be literal strings. There should be no variables, concatenation, constants or even a t() call there. At watchdog('node_gallery',t('Node gallery delete form: %name deleted.',array('%name'=>$form_state['values']['gallery_name'])),WATCHDOG_NOTICE) in node_gallery.admin.inc on line 578. Read more at http://drupal.org/node/323101
    * node_gallery_perm() should have an array of literal string permission names. In node_gallery.module. Read more at http://drupal.org/node/323101
    * Invalid menu 'description' definition found in node_gallery_menu(). Title and description keys of the menu array should be literal strings. In node_gallery.module on line 49. Read more at http://drupal.org/node/323101
    * Invalid menu 'description' definition found in node_gallery_menu(). Title and description keys of the menu array should be literal strings. In node_gallery.module on line 62. Read more at http://drupal.org/node/323101
    * The first parameter to t() should be a literal string. There should be no variables, concatenation, constants or other non-literal strings there. At t("Specify the image display when viewing a gallery need inputing password. The root is the web root. The default file is $default") in contrib/node_gallery_access/node_gallery_access.admin.inc on line 15. Read more at http://drupal.org/node/322732
    * The first parameter to t() should be a literal string. There should be no variables, concatenation, constants or other non-literal strings there. At t("Specify the image display when viewing an image need inputing password. The root is the web root. The default file is $default") in contrib/node_gallery_access/node_gallery_access.admin.inc on line 21. Read more at http://drupal.org/node/322732
    * node_gallery_access_perm() should have an array of literal string permission names. In contrib/node_gallery_access/node_gallery_access.module. Read more at http://drupal.org/node/323101
    * The first two watchdog() parameters should be literal strings. There should be no variables, concatenation, constants or even a t() call there. At watchdog('node_gallery',t('Node gallery delete form: %name deleted.',array('%name'=>$form_state['values']['gallery_name'])),WATCHDOG_NOTICE) in node_gallery.admin.inc on line 578. Read more at http://drupal.org/node/323101
    * node_gallery_perm() should have an array of literal string permission names. In node_gallery.module. Read more at http://drupal.org/node/323101
    * Invalid menu 'description' definition found in node_gallery_menu(). Title and description keys of the menu array should be literal strings. In node_gallery.module on line 49. Read more at http://drupal.org/node/323101
    * Invalid menu 'description' definition found in node_gallery_menu(). Title and description keys of the menu array should be literal strings. In node_gallery.module on line 62. Read more at http://drupal.org/node/323101
    * The first parameter to t() should be a literal string. There should be no variables, concatenation, constants or other non-literal strings there. At t("Specify the image display when viewing a gallery need inputing password. The root is the web root. The default file is $default") in contrib/node_gallery_access/node_gallery_access.admin.inc on line 15. Read more at http://drupal.org/node/322732
    * The first parameter to t() should be a literal string. There should be no variables, concatenation, constants or other non-literal strings there. At t("Specify the image display when viewing an image need inputing password. The root is the web root. The default file is $default") in contrib/node_gallery_access/node_gallery_access.admin.inc on line 21. Read more at http://drupal.org/node/322732
    * node_gallery_access_perm() should have an array of literal string permission names. In contrib/node_gallery_access/node_gallery_access.module. Read more at http://drupal.org/node/323101
    * The first parameter to t() should be a literal string. There should be no variables, concatenation, constants or other non-literal strings there. At t("Specify the image display when viewing a gallery need inputing password. The root is the web root. The default file is $default") in node_gallery_access/node_gallery_access.admin.inc on line 15. Read more at http://drupal.org/node/322732
    * The first parameter to t() should be a literal string. There should be no variables, concatenation, constants or other non-literal strings there. At t("Specify the image display when viewing an image need inputing password. The root is the web root. The default file is $default") in node_gallery_access/node_gallery_access.admin.inc on line 21. Read more at http://drupal.org/node/322732
    * node_gallery_access_perm() should have an array of literal string permission names. In node_gallery_access/node_gallery_access.module. Read more at http://drupal.org/node/323101
    * The first parameter to t() should be a literal string. There should be no variables, concatenation, constants or other non-literal strings there. At t("Specify the image display when viewing a gallery need inputing password. The root is the web root. The default file is $default") in node_gallery_access/node_gallery_access.admin.inc on line 15. Read more at http://drupal.org/node/322732
    * The first parameter to t() should be a literal string. There should be no variables, concatenation, constants or other non-literal strings there. At t("Specify the image display when viewing an image need inputing password. The root is the web root. The default file is $default") in node_gallery_access/node_gallery_access.admin.inc on line 21. Read more at http://drupal.org/node/322732
    * node_gallery_access_perm() should have an array of literal string permission names. In node_gallery_access/node_gallery_access.module. Read more at http://drupal.org/node/323101

dbeall’s picture

I see old stuff in there. The strings have changed in the OCT 28th dev

dbeall’s picture

maybe not, the access patch has yet to go in.

kmonty’s picture

Title: Translation template for module » Ensure Node Gallery Meets Drupal Coding Standards to Allow for Translation
Priority: Minor » Critical
Status: Needs work » Active

Damn it.

kmonty’s picture

Title: Ensure Node Gallery Meets Drupal Coding Standards to Allow for Translation » Create Translation template for Node Gallery

Fixed the translation issues. Still need a template though so I'll leave the ticket open.

kmonty’s picture

Priority: Critical » Minor
dbeall’s picture

StatusFileSize
new2.4 KB
new5.32 KB
new18.1 KB

Thank you NancyDru for the quick HowTo!
Now I wish I knew a bunch of languages, but I only have English.

here is what I have after the new nga-1.patch was applied from
http://drupal.org/files/issues/nga-1.patch

and with patch for image sorting page from
http://drupal.org/files/issues/node_gallery-603600.patch

so, if these patches go in, this will be ok pending further changes.

It didn't pick up the views.inc..?
also, are the install files to be translated..? they are in there.

nancydru’s picture

Yes, I have all the files as part of my templates.

dbeall’s picture

My mistake, it picked up the strings from views.inc.. but the top of the template has

# node_gallery.token.inc,v 1.2.4.12 2009/10/09 05:29:04 kmonty
# node_gallery.views.inc: n/a
# node_gallery.info: n/a

because there is no ( // &Id: information..) in the views.inc and .info files.

EDIT:looks like these are missing // &Id:[...] too.
# node_gallery_lightbox2.install: n/a
# node_gallery_access.info: n/a

dbeall’s picture

StatusFileSize
new27.93 KB

I missed this selection with the extraction part of the translation module.
The OP has all directories included in the one file.
Duuuuu. all I had to do was look!

suffering drupal’s picture

Hello!
I understood/hoped that this meant that one "Node Gallery" gallery could be used in several languages, but I have the impression it is only about translating words?
Is it possible to avoid having to duplicate each gallery for each new language?
Thanks

dbeall’s picture

Just a reminder,, the pot file has to be re-created with any new release to include any changes.
@maintainers
This should be done last, just before a new release is packaged
-or-
It would help to have a 'string freeze' for node_gallery so folks can work on the translations to include the files with the new release.

@suffering drupal
each language translator has to create the file for their language, then it can be added to the package.
After each language file is added, then it will be available for everyone.

suffering drupal’s picture

Hi dbeall, thanks for the fast answer, but maybe I have not explained myself well.
I am not worried about translation of the text. I am worried about the "translation" of the images!

Of course, images don't need translation, but it seems that, when you create a new translation, Node Gallery wants you to upload the pictures AGAIN, in other words you're just creating a new gallery with the same pictures.
That's not efficient. And undoable if you want to do some dozen pictures of some hundred monuments in some 4 languages.
So, I hope you can tell me how one can translate a Node Gallery to other languages without having to upload the same images again for each language.
Many thanks on beforehand!

dbeall’s picture

@suffering drupal
sorry, I didn't understand the problem. I would advise opening or creating a new issue for this. If you create the issue, you will be on the receiving end when updates are made..

Title "Multi language Node Gallery without having to upload the same images again for each language."
component "code"
assigned "anonymous"
category "feature request"
status "active"
priority "normal"

dddave’s picture

As soon as we reach RC-status I can provide a German translation. I don't think we should begin translating beforehand, do we?

suffering drupal’s picture

@dbeall

done!

dbeall’s picture

@dddave, I know your right, there could be a few changes pop up.
I haven't seen any type of road map for node_gallery to have an idea about releases.
I suppose there is 2, maybe 3 critical RC blockers right now...

I am so impressed when people know 2 or more languages.
I have a rough time with words. My grandmother had a PHD in English, was a professor at Ohio University and traveled to France and Germany to absorb the languages. I must be a disappointment..

dbeall’s picture

Status: Active » Fixed

I think this can be safely marked as fixed as far as the template goes.
It would be neat to get a few completed translations to add to the module package.

http://drupal.org/node/683312#comment-2472116 ,here is a po template for alpha12 with the updated code

http://drupal.org/files/issues/node_gallery_2.pot

dddave’s picture

dbeall’s picture

StatusFileSize
new23.67 KB

There was a few small changes which in turn had changed some line numbers, and a few small text changes. This template from 6.x-2.x-dev 2010-Jan-16

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.