See the patch.

CommentFileSizeAuthor
#4 l10n_server-357471.patch3.78 KBtobiasb
#1 l10n_community-xhtml-css-corrections.patch5.44 KBtobiasb
l10n_community-tables.patch3.94 KBtobiasb

Comments

tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented
StatusFileSize
new l10n_community-xhtml-css-corrections.patch5.44 KB

wrong patch

tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented
Status: Active » Needs review
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Needs work

- I get and see the usefulness of the change from id="l10n-community-overview" to class="l10n-community-overview". We sometimes have multiple tables with the same ID.
- I understand why you modified <b><b> to strong, but there might be some JS which needs to be modified there. The bold tag is usually used as JS / CSS targets to hook onto.
- I don't think that table summaries like "Left table" or "Right table" have anything to tell, especially the summary "An table".
- I don't get why you modified a definition list to a div.

tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented
StatusFileSize
new l10n_server-357471.patch3.78 KB

Ok, I remove strong and the summaries. A form (1) is inside in dl, therefore I changed this to div. And the rest is only id => class.

1)

<dl class="admin-list"><form action="/translate"  accept-charset="UTF-8" method="post" id="l10n-community-pick-go">
<div><div class="form-item" id="edit-project-wrapper">
[.........]
<input type="hidden" name="form_id" id="edit-l10n-community-pick-go" value="l10n_community_pick_go"  />
</div></form>
<div class="clearing"></div></dl>
tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented
Status: Needs work » Needs review
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Fixed

Thanks. Except the 45% -> auto change for the table, which breaks the language and project overview pages, I've committed all your suggested changes. Good work!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.