The Image cache module documentation recomends using the transliteration module and altering the theme_imagecache function. Going this way prevents a clean update of the image cache module since it is necessary to edit the file after each update.
As the altered theme_imagecache function checks the existence of the transliteration module it makes no harm to include this function by default in the image cache module.

CommentFileSizeAuthor
#13 imagecache_357569.patch905 bytesdrewish
#5 imagecache_with_transliteration.patch789 bytesthepanz
#4 imagecache.module.patch592 bytessmitty

Comments

deleuje’s picture

deleuje commented

Good idea. I second this.

drewish’s picture

drewish commented

roll a patch. as it is i'm happy with just recommending this.

rbl’s picture

rbl commented

Hi!
The theme_imagecache function in the module looks more complex than the one on the documentation page.
Is that code up to date?

Thanks!
Ricardo

smitty’s picture

smitty commented
Version: 6.x-2.0-beta5 » 6.x-2.0-beta8
Status: Active » Needs review
StatusFileSize
new imagecache.module.patch592 bytes

Here comes a patch. I've tested it only whith the 5.x-2.3 version. But it should also work with the 6.x-2.0-beta8.

thepanz’s picture

thepanz commented
StatusFileSize
new imagecache_with_transliteration.patch789 bytes
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

+1 for the feature; as there is already a module that handles the transliteration of the strings used in Drupal, it would be better to use that module to avoid the duplication of existing code.
Then, the code to keep updated in case of bugs would be reduced.

smitty’s picture

smitty commented

I think, the patches #4 and #5 are identical.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

Actually, they aren't; the initial offset reported is different (775,6 versus 697,6).

thepanz’s picture

thepanz commented

@smitty: I took the edits from #4 and changed the 6.x module version, nothing more! :)

smitty’s picture

smitty commented

Fine! Then we have a patch for Drupal 5.x (#4) and for Drupal 6.x (#5).

drewish’s picture

drewish commented

marked #369193: Image src not properly URL encoded #447156: Needing only a url from imagecache as a duplicates.

thepanz’s picture

thepanz commented

@drewish: we'll see this patch merged in next -beta10 release?

drewish’s picture

drewish commented
StatusFileSize
new imagecache_357569.patch905 bytes

i think this might be a better place to put it.

drewish’s picture

drewish commented
Status: Needs review » Fixed

committed to HEAD.

smitty’s picture

smitty commented

Will there be a rollback to 5.x?

drewish’s picture

drewish commented

yeah, going to fold that into the backport of #347566: Require transliteration module.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.