Download & Extend
ImageCache » Issues

Add support for transliteration in the module

Posted by gorbeia on January 12, 2009 at 8:55am
Project:ImageCache
Version:6.x-2.0-beta8
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

The Image cache module documentation recomends using the transliteration module and altering the theme_imagecache function. Going this way prevents a clean update of the image cache module since it is necessary to edit the file after each update.
As the altered theme_imagecache function checks the existence of the transliteration module it makes no harm to include this function by default in the image cache module.

Login or register to post comments

Comments

#1

Posted by deleuje on January 13, 2009 at 8:33pm

Good idea. I second this.

#2

Posted by drewish on January 14, 2009 at 12:31am

roll a patch. as it is i'm happy with just recommending this.

#3

Posted by rbl on February 24, 2009 at 9:40am

Hi!
The theme_imagecache function in the module looks more complex than the one on the documentation page.
Is that code up to date?

Thanks!
Ricardo

#4

Posted by smitty on March 30, 2009 at 4:37pm
Version:6.x-2.0-beta5» 6.x-2.0-beta8
Status:active» needs review

Here comes a patch. I've tested it only whith the 5.x-2.3 version. But it should also work with the 6.x-2.0-beta8.

AttachmentSizeStatusTest resultOperations
imagecache.module.patch592 bytesIgnored: Check issue status.NoneNone

#5

Posted by thePanz on April 14, 2009 at 5:54pm
AttachmentSizeStatusTest resultOperations
imagecache_with_transliteration.patch789 bytesIgnored: Check issue status.NoneNone

#6

Posted by kiamlaluno on April 14, 2009 at 9:36pm

+1 for the feature; as there is already a module that handles the transliteration of the strings used in Drupal, it would be better to use that module to avoid the duplication of existing code.
Then, the code to keep updated in case of bugs would be reduced.

#7

Posted by smitty on April 15, 2009 at 12:16pm

I think, the patches #4 and #5 are identical.

#8

Posted by kiamlaluno on April 15, 2009 at 1:30pm

Actually, they aren't; the initial offset reported is different (775,6 versus 697,6).

#9

Posted by thePanz on April 15, 2009 at 2:10pm

@smitty: I took the edits from #4 and changed the 6.x module version, nothing more! :)

#10

Posted by smitty on April 15, 2009 at 2:15pm

Fine! Then we have a patch for Drupal 5.x (#4) and for Drupal 6.x (#5).

#11

Posted by drewish on April 29, 2009 at 3:12pm

marked #369193: Image src not properly URL encoded #447156: Needing only a url from imagecache as a duplicates.

#12

Posted by thePanz on April 29, 2009 at 5:27pm

@drewish: we'll see this patch merged in next -beta10 release?

#13

Posted by drewish on April 29, 2009 at 6:33pm

i think this might be a better place to put it.

AttachmentSizeStatusTest resultOperations
imagecache_357569.patch905 bytesIgnored: Check issue status.NoneNone

#14

Posted by drewish on May 3, 2009 at 6:50pm
Status:needs review» fixed

committed to HEAD.

#15

Posted by smitty on May 4, 2009 at 12:12pm

Will there be a rollback to 5.x?

#16

Posted by drewish on May 7, 2009 at 3:02pm

yeah, going to fold that into the backport of #347566: Require transliteration module.

#17

Posted by System Message on May 21, 2009 at 3:10pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here