D6 theme on project page

Summit - January 12, 2009 - 15:47
Project:Vertigo
Version:6.x-1.x-dev
Component:Code
Category:task
Priority:normal
Assigned:Unassigned
Status:active
Description

Hi,
I noticed that only the D5 theme instance is shown on project-page.
May be handy also to show D6 dev. theme.

Will there become a 1.0 version soon please?

Thanks a lot in advance for considering this issue.

Greetings,
Martijn

#1

peterx - March 2, 2009 - 19:55

Testing of the development theme at http://d-theme.com/vertigo shows there are only a few things to fix in the HTML to have a valid theme. The doctype is XHTML 1.0 Transitional and all testing at D-theme is against XHTML 1.0 Strict.

The page.tpl.php file contains the following line, which was OK in Drupal 5.
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en">

For Drupal 6, you need:
<html xmlns="http://www.w3.org/1999/xhtml" lang="<?php print $language->language; ?>" xml:lang="<?php print $language->language; ?>" dir="<?php print $language->dir; ?>">

The page.tpl.php file is missing the following line and it goes straight after the html line.
<head>

The following line has an improperly nested heading, a WAI AA issue.
<h2 class="content-title">

The following line contains a style attribute and the default style sheet language is not specified. The best solution is to make the style into a class.
<div style="clear:both;">

 
 

Drupal is a registered trademark of Dries Buytaert.