current cvs, comment.module, line 897.

if (db_num_rows($result) && (variable_get('comment_controls', 3) == 1 || variable_get('comment_controls', 3) == 3)) {

this shows comment controls at the bottom for values 1 (below) and 3 (do not display). the 2nd == should check for value 2 (both above and below).

Comments

asimmonds’s picture

asimmonds commented

Duplicate of / related to http://drupal.org/node/34295 ?

I think these numbers used to refer to the comment control position should be constants, it's too confusing otherwise. If I get some time, I'll file a patch to change them.

mindless’s picture

mindless commented

yes, the second portion of that report is the same as what i describe here.

dries’s picture

dries commented

It would be a good idea to introduce some defines.

asimmonds’s picture

asimmonds commented
Status: Needs review » Closed (duplicate)

I'm settings this as duplicate as I've put a defines patch on to http://drupal.org/node/34295, fixing this bug as well.