sync'd images removed by cron?

I am having this issue too.
Any solutions?

I can't imagine why this would happen, but it'd be great if you could help debug this further. To start with, can you reproduce the problem without FlickrSync by just using the ImageField and/or FileField modules by themselves?

I have other imagefields, but only the one associated with FlickrSync is being removed

I think this just happened to me, also. I ran cron and it imported all my new images since the last import, but removed all my old ones! The thumbs are still in the directory but all the originals are gone, as reported.

In addition, I got a ton of these errors, which I'm not sure are related - those are really weird, I had no files named anything like these filenames on my site, but I thought I'd show them in case they are a clue.

    * warning: unlink(/tmp/currency.1031.1894.uo8rrp.cache) [function.unlink]: Operation not permitted in /home/ellyjonez/dev.elly.org/sites/all/modules/flickrapi/phpFlickr/phpFlickr.php on line 139.
    * warning: unlink(/tmp/bestsellers.1031.1894.uo8rrp.cache) [function.unlink]: Operation not permitted in /home/ellyjonez/dev.elly.org/sites/all/modules/flickrapi/phpFlickr/phpFlickr.php on line 139.
    * warning: unlink(/tmp/prices.4.1031.1894.uo8rrp.cache) [function.unlink]: Operation not permitted in /home/ellyjonez/dev.elly.org/sites/all/modules/flickrapi/phpFlickr/phpFlickr.php on line 139.
    * warning: unlink(/tmp/prices.5.1031.1894.uo8rrp.cache) [function.unlink]: Operation not permitted in /home/ellyjonez/dev.elly.org/sites/all/modules/flickrapi/phpFlickr/phpFlickr.php on line 139.
    * warning: unlink(/tmp/prices.1.1031.1894.uo8rrp.cache) [function.unlink]: Operation not permitted in /home/ellyjonez/dev.elly.org/sites/all/modules/flickrapi/phpFlickr/phpFlickr.php on line 139.
    * warning: unlink(/tmp/prices.2.1031.1894.uo8rrp.cache) [function.unlink]: Operation not permitted in /home/ellyjonez/dev.elly.org/sites/all/modules/flickrapi/phpFlickr/phpFlickr.php on line 139.
    * warning: unlink(/tmp/prices.105.1031.1894.uo8rrp.cache) [function.unlink]: Operation not permitted in /home/ellyjonez/dev.elly.org/sites/all/modules/flickrapi/phpFlickr/phpFlickr.php on line 139.
    * warning: unlink(/tmp/prices.104.1031.1894.uo8rrp.cache) [function.unlink]: Operation not permitted in /home/ellyjonez/dev.elly.org/sites/all/modules/flickrapi/phpFlickr/phpFlickr.php on line 139.
    * warning: unlink(/tmp/upsales.1031.1894.uo8rrp.cache) [function.unlink]: Operation not permitted in /home/ellyjonez/dev.elly.org/sites/all/modules/flickrapi/phpFlickr/phpFlickr.php on line 139.

:( :(

Hmmm...experiencing the exact same behavior...odd though, out of all images a few do remain.

Subscribing to a solution.

I found a related issue somewhere else, but for another function file_save_upload. Maybe change field_file_save_file to the file_save_upload function together with file_set_status($file, FILE_STATUS_PERMANENT);? Seems files are not saved properly when cron runs before it is saved to the table? Just shooting one of in the dark here, but I do think the issue lies somewhere in this code.

In D6, files now have a status. By default, the uploaded file is considered temporary and will be deleted on the next cron run after 24 hrs. So, if there is a file_save_upload and the same function does not include file_set_status($file, FILE_STATUS_PERMANENT);, it would be nice to issue a warning that the file may be deleted as a temporary file.

Regards,

Marius

I added the following code to the flickrsync_download_photo function below the field_file_save_file line that Marius was referring to:

$tempfile = (object)$file;
file_set_status($tempfile, FILE_STATUS_PERMANENT);

After importing and updating flickr images, I checked the files table and the file status was changed from 0 to 1.

Phil

--

I'm also having this problem.

Using Drupal 6, image_cache, cck image field, and a views slideshow. When I initially setup my images and sync them from flickr the slideshow is working great. I have views slideshows generated based on my Flickr images. Then I check the next day, I believe after cron has run. No slideshow, no images showing up until I go to the node and 'update from flickr'.

Any working fixes? I'm going to make sure I'm using the latest version of all related modules, try new image cache presets. Anyone have a fix for this?

Ok well after some trouble shooting and re-reading of this thread I think I have got everything working correctly (for my specific needs).

The problem was any time cron ran the images would disappear. The original files were being deleted. The images would also disappear if I ran "Update from Flickr" on any node created with Flickr Sync.

I added this: around line 789 of flickrsync.module

if ($file = field_file_save_file($filename, array(), $directory, TRUE)) {
    //if ($file = file_save_upload($filename, array(), $directory, TRUE)) {
    // file_set_status($file, FILE_STATUS_PERMANENT);
    $tempfile = (object)$file;
    file_set_status($tempfile, FILE_STATUS_PERMANENT);
    ...

When I tried file_save_upload as recommended above my images were not saving properly unless I'm using it incorrectly but the params all seem to match up with the description in the drupal API.

After adding the above code the images are not disappearing when cron runs and new images are automatically imported / created. If I run "Update from Flickr" on any flickr sync node the images still disappear.

So it seems to be working ok as long as no one ever uses the "Update from Flickr" link. I haven't noticed any other issues yet and I have ran cron a number of times to verify that newly tagged Flickr photos automatically start showing up in my slideshow.

*edit*

Another note after some more testing I was wondering if I could untag images in Flickr and then they would then be unpublished / deleted from my site when cron runs the 'flickr-sync'. The images remain published / active. Are they supposed to get unpublished if the tag is removed on flickr? That is the point of a 'sync' correct?

Maybe this is related to the above edits?

I'll just manually unpublish any images I don't want for now.

Taking a look at this, I see the likely culprit being line 667 in the flickrsync.module file:
$file = flickrsync_download_photo($flickr_photo, 'largest');

When flickrsync_download_photo returns false (often timing out with Flickr), $file stores as FALSE. However, since there is no check for $file, it continues to rebuild the node and submit it with an empty file. Below is the suggested fix:

// get the path to the largest available image size (cached locally)
$file = flickrsync_download_photo($flickr_photo, 'largest');
if (!$file) {
drupal_set_message(t("Couldn't download file, unable to save image %photo_id", array('%photo_id' => $photo_id)));
return FALSE;
}

Since this happens sporadically, I'm still checking to see if this does the trick.

glove - interested to know if this solution worked for you. please update us!

With glove's change (#19), I've added the file_set_status of internets (#18)

So far this is working on my test system. Entries in the files table are saved with a status of "1" instead of "0" and are not removed during cron runs. I overwrote the DRUPAL_MAXIMUM_TEMP_FILE_AGE in settings.php to be able to test this in minutes vs hours. ( define('DRUPAL_MAXIMUM_TEMP_FILE_AGE', 300); )

The following code is the patch:

--- flickrsync.module.orig 2008-10-31 18:00:51.000000000 -0500
+++ flickrsync.module   2009-12-18 12:25:05.000000000 -0600
@@ -665,6 +665,13 @@

   // get the path to the largest available image size (cached locally)
   $file = flickrsync_download_photo($flickr_photo, 'largest');
+  if (!$file) {
+    drupal_set_message(t("Couldn't download file, unable to save image %photo_id", array('%photo_id' => $photo_id)));
+    return FALSE;
+  }
+  // Set file to permanent status so it isn't cleaned up later
+  $fileobj = (object)$file;
+  file_set_status($fileobj, FILE_STATUS_PERMANENT);

   $content = '';
   if ($flickr_photo['description']) {

There hasn't been any activity on this thread for around 6 months, but I have recently installed Flickr Sync and am having this issue so I figure its still a problem.

I am going to test the patch above in #21 and I'll post results. Any idea on when this issue will be fixed in the release?

The patch seems to have fixed the problem. My site has been running for about a week now without losing any of the images.

However, I know have an issue with the number of photos imported. In the settings, the maximum number of flickr images to import during each cron run isn't working as it should. With the value set to 5, the same 5 images are imported over and over, so I never had more then 5 images. I've changed this number to 40, but now I'm limited to 40 images. I'm not sure if this is a separate issue, or an issue caused by the patch. I'm going to look for another thread or open a new one.

Subscribing.

I have tested and committed the patch in #357711-21: sync'd images removed by cron?. Marking this issue as fixed.