With 2.9 version the admins can change the text, but this creates a whole new problem for multilingual sites: the new text that we enter cannot be translated into other languages.

I think you need to put t() around that variable.

Comments

kbahey’s picture

kbahey commented
Status: Active » Closed (won't fix)

Variables should not be translated using t().

For the long answer, read this http://api.drupal.org/api/function/t/5

This is the same case as the "mission" variable in Drupal core, which is not translatable.

drupalina’s picture

drupalina commented
Status: Closed (won't fix) » Postponed (maintainer needs more info)

Alright, then please let us know what are we supposed to do with this new 2.9 way in case of multilingual sites, which need to display "Report this page" in different languages.

thanks

kbahey’s picture

kbahey commented
Priority: Critical » Normal

As I said, core has the same issue, for example, the Mission settings.

When core has a solution for this, it should apply to contrib modules as well.

drupalina’s picture

drupalina commented

Right now I'm tempted to revert back to the old version of "Flag content" module.

But, it's better to go forward than back. So let's work on this step by step ;)

Here is an interesting solution:
http://drupal.org/node/134002 ...so if you could tell me the low level name for the "Report this page" variable , then that could be a start.

Another solution that I have up and running on my live site for many months now is precisely to put things in t() . For instance, I have site slogan in my page.tpl.php written as t($site_slogan) and I have my footer message printing as t($footer_message) .. And it has never given me any trouble -- works like a charm. And there are many modules that do this and it works very well.

kbahey’s picture

kbahey commented
Status: Postponed (maintainer needs more info) » Postponed

As I said, t($something) is not a solution. It is problematic in many ways.

Read this http://groups.drupal.org/node/15177

I know that it is a problem, but even Drupal core has it, not this module. Once Drupal has a solution, I am happy to accept a patch that implements it.

pomliane’s picture

pomliane commented
Status: Postponed » Closed (won't fix)

This version of Flag content is not supported anymore. The issue is closed for this reason.
Please upgrade to a supported version and feel free to reopen the issue on the new version if applicable.

This issue has been automagically closed by a script.