This patch should fix that right up. =)

CommentFileSizeAuthor
#3 uc_file.fix_wanton_notifications.patch395 bytescha0s
ca.features.patch5.64 KBcha0s

Comments

Island Usurper’s picture

Island Usurper commented
Status: Needs review » Needs work

I think these conditions could be useful, but I don't think they address the underlying issue. With this patch, someone could go into the notification predicates and remove that condition, and all orders suddenly get emails about their new, nonexistent roles and files.

As far as I remember, the only time the notifications are triggered is in the renew actions of those modules. I think uc_roles_action_order_renew() does the right thing in that it only triggers the email when a role feature is in the order. So, only uc_file_action_order_renew() actually needs to be changed.

cha0s’s picture

cha0s commented

The issue was brought about by emails getting fired off incorrectly... So I guess that check will have to be added to all them too... I figured a CA solution was nicer than a code solution. If someone removes those conditions, then it's not our fault... ;p

cha0s’s picture

cha0s commented
Status: Needs work » Needs review
StatusFileSize
new uc_file.fix_wanton_notifications.patch395 bytes

Alright, Ryan voted for your solution... so the new proposed patch follows. =)

I still feel like it'd be nice to have those conditions in place, but this will function the same.

Island Usurper’s picture

Island Usurper commented
Status: Needs review » Fixed

Thanks. Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.