jCarousel for Drupal 6 is now out, and the API is pretty handy. Might be a good idea to switch to use that instead of Views Carousel implementation.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | viewscarousel_revamp-358213-8.patch | 62.28 KB | neclimdul |
| #7 | viewscarousel_revamp-358213-7.patch | 62.21 KB | neclimdul |
| #5 | viewscarousel_revamp.358213.5.patch | 62.18 KB | neclimdul |
| #4 | viewscarouselrevamp.patch | 65.78 KB | robloach |
| #3 | viewscarouseljcarousel.patch | 61.26 KB | robloach |
Comments
Comment #1
robloachWell this certainly removes quite a bit of code.............. Make sure to also delete the images. The -binary patch includes the binary files, the first one does not.
Now depends on the jCarousel module.
......Nice job on the module, it's pretty awesome. The Views 2 API is wicked.
Comment #2
robloachOne thing that's not included in this patch is the ability to make use of the JavaScript callbacks. the jCarousel module for Drupal 6 supports the ability to send in the callback functions for initCallback, etc.... This patch doesn't allow you to set those from the View configuration. Maybe in a future patch?
Comment #3
robloachAdding this fixes a lot of issues in the Views Carousel issue queue..... Requires at least jCarousel 6.x-1.1.
Comment #4
robloachSorry, wrong patch.
Comment #5
neclimdulVery cool, +1 to minimizing external libs in contrib.
Slight tweak of Rob's patch to use the dependency javascript to control this skin path field and adjusting the description to fit this.
Comment #6
robloachComment #7
neclimdulFound a sort of bug where if you didn't empty the custom CSS file before selecting a different theme it would still be added. Not a likely workflow but this patch still fixes it. Trivial argument validation fix so not dropping it out of RTBC.
Comment #8
neclimdulthe real patch
Comment #9
robloachAwesome work! Committed and viewscarousel 6.x-2.x-dev opened. I like how the custom skin path disappears when custom skin isn't chosen............Think we could add a hook_jcarousel_skin() to the jCarousel module or something to list the skins?
Any other problems with it should be handled in new issues.
Comment #11
asak commentedNote: it isn't clear from the projects page that jCarousel module is a dependency now.