Hi,

Attached is a patch to tidy up taxonomy_context.module for 4.7/HEAD. It includes some changes to bring it up to scratch:

* node_list is deprecated: http://drupal.org/node/22218#node_list
* node_load can be called with a single parameter of node id (nid): http://drupal.org/node/22218#node_load
* Form API!

I've also tidied some parts of the code up, including trailing whitespace, spaces after closing ?>, and using ' instead of " to delimit strings where applicable.

This has been tested briefly tonight, buts its running on my site so if anything else crops up I'll post it here. Please test and review!

Cheers.

CommentFileSizeAuthor
taxonomy_context_formsapi_and_47_tidy.patch31.81 KBpfaocle

Comments

pfaocle’s picture

pfaocle
He/Him
Primary language English
commented
Status: Active » Needs review

Whoops.

nedjo’s picture

nedjo
he/him/his
Primary language English
commented

Paul,

Thanks very much for this. Please go ahead and apply the patch to CVS head. I have a number of additional changes I want to make (mainly, removing unneeded stuff), and will do so after you apply the patch.

Nedjo

pfaocle’s picture

pfaocle
He/Him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

I don't have CVS access, unfortunately...

nedjo’s picture

nedjo
he/him/his
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Thanks, applied. Some further work needed (raising errors, maybe due to changes since this patch was generated), but this is a good start.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)