Date and Time Fields Loose Value in Multipage Forms

Confirmed! Storing date fields is messed up for forms that includes page breaks. I've also noticed a funny issue with time! If you try to store a "single digit value" for hours (0-9), that number will be stored in the database correctly, but if you'll try to view your submission at node/X/submission/Y, the number won't appear in a combo box (take a look at the attachment).

Btw, I resubmitted the webform at node/X/edit AND node/X/edit/components right after I've finished with update.php.

Confirmed here as well. Very annoying, as I have multi-page forms with a large number of fields. It was working in 5.x-2.3 and the bug was apparently introduced in the 5.x-2.4 release.

Could you confirm this TIME issue as well?

I don't use the TIME type. Will check if I find a little moment to do so.

Re comment #1 above: recreating the whole form does not solve the problem in case of forms with pagebreaks.

Confirmed: recreating the whole form does not solve the problem in case of forms with pagebreaks.

This was caused by #328528: Checkbox values in form_state rendered incorectly.. Apologies that this was not caught before releasing the new version. I believe it affects both Drupal 5 and Drupal 6 versions. This problem causes data loss, so I'm moving back up to critical.

I can confirm this also affects version 6.x-2.4

Is there any temporary workaround for this critical issue? Any suggestions?

The referenced issue whose patch seems to have broken this (#328528: Checkbox values in form_state rendered incorectly.) ended up being patched with a one line change. If you remove / comment out that line the date handling seems fixed but you are back to the check box values in form_state being rendered incorrectly. This is a much less severe problem, though, unless there is some other bad behavior that I don't know about.

I am using 6.x-2.4. The offending line is line 1664 in the webform_client_form_submit function in webform.module:

  _webform_client_form_submit_process($node, $form_state['values']['submitted']);

Just remove that or comment it out.

As always proceed with caution with my suggestion above. I am one person doing light testing and certainly not any official voice of the webform module. We are but mere acquaintances.

@TMSA #12: This approach seems to fix 5.x-2.4 issue as well.

A Time issue I've described previously is still present, but I doubt it's related with this Date issue.
I can receive an e-mail notification with the exact time and I don't see a problem in an e-mail report, but when I'd like to view the submission result online, the HOUR select field is set to it's default value: "hour".

The problems introduced by #328528: Checkbox values in form_state rendered incorectly. are a bit difficult to overcome for types like date and time (where the submitted value is not the same as the saved value). However, it's definitely needed to keep checkboxes and grid components from loosing their values. The temporary work-around I've done is only have this processing occur on select and grid components, so things should work for those components while not breaking time and date. This is a pretty bad bug, I'm trying to get out a 2.5 release this weekend.

@quicksketch: Could you reproduce that "time issue" I've previously described? Date issue has gone, but Time issue is still present even with this patch on my Drupal page (patched 5.x.2.4 webform module)... the number (of hours) has been stored in the database perfectly correct each time after a submission, but the preview doesn't show the correct value.

I still experience a strange Time issue and this time I've noticed that a value 00:15 (HH:MM) is not even being mailed correctly (I've received an empty value), but it's written in an adequate format within the database. If I'd like to view the submission, the same issue appears as described here in #3, #14 and #17. This bug is driving me crazy...

Unless the time problem affects the Drupal 6 version of Webform, this will probably stay as "won't fix" (though that's not what I'm marking it because the original problem has been fixed). I haven't used Drupal 5 in 2 years now, it's time to upgrade.

Hello,

We were having the same issue as #3 -- 'If you try to store a "single digit value" for hours (0-9), that number will be stored in the database correctly, but if you'll try to view your submission at node/X/submission/Y, the number won't appear in a combo box (take a look at the attachment).'

This is caused by a bug in the function _webform_submission_display_time on line 210:

$form_item['hour']['#default_value'] = date('H', $timestamp);

This should read:

$form_item['hour']['#default_value'] = date('G', $timestamp);

I have attached a patch file against webform 5.x-2.9 which makes this change.

I haven't had time to test the drupal 6 version, but looking at the code suggests that this also affects webform 6.x-2.9

Thanks,
Pete

Marking as needs review, esp. because potentially in 6.x-2.9 too.

This probably won't ever be fixed, support for Drupal 5 is now completely ended. I suggest upgrading to Drupal 6 and the 3.x version of Webform.