After upgrading to 2.3, I started getting a permalink visible on views (blocks and pages) that was broken (see attached screenshot). The html looked like this:

<a href="http://marinemetadata.org/" title="Permalink to: Recent Metadata News">#</a>

After poking around, I found that the views_post_query hook was returning a permalink for all views, not just project-related ones. I modified to use the same switch method that is being used for the views_pre_view hook. Patch attached.

CommentFileSizeAuthor
project_issue.module.patch.txt1.5 KBp_alexander
permalink_broken.png3.65 KBp_alexander

Comments

dww’s picture

dww
we/he/they
commented
Status: Needs review » Fixed

Yup, I had noticed the same thing a while ago and forgot to file and issue about it or fix it. ;) Thanks for the patch. I simplified some of the code a bit, tested, and committed to DRUPAL-5--2. I'm not committing to HEAD since project_issue.views.inc is going to be completely re-written for #76725: Refactor project issue module to use Views.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

MartysMind’s picture

MartysMind commented
Priority: Normal » Critical
Status: Closed (fixed) » Reviewed & tested by the community

Reviewed and tested patch. Tested OK.

Project Issues with this bug cannot be used on active sites.

dww’s picture

dww
we/he/they
commented
Priority: Critical » Normal
Status: Reviewed & tested by the community » Closed (fixed)

The bug has already been fixed. You can use the 5.x-2.x-dev code if you want, or apply the patch. An official 5.x-2.4 release will come out including this fix at some point, once enough other bugs are fixed.

j0nathan’s picture

j0nathan commented

Subscribing because it's still in dev and I encountered pound signs before applying the patch.