Conflict with Registration Role

Posted by affinitymc on January 15, 2009 at 5:57am

Issue Summary

I installed Registration Role (RR) and it was working fine. I then installed LT, and although RR initially assigns the correct role upon registration, when LT processes the confirmation email it drops the assigned role. Here is the code from Registration Role that I assume assigns the role:

/**
 * Implementation of hook_user().
 *
 * Catch every registration and insert role
 */

function registration_role_user ($op, &$edit, &$user, $category=null)
{
  if ($op == "insert" && $rid = variable_get('registration_role_roles', ''))
  {
    // below does not seem safe!  or necessary for insert. Commented out
    // clear first
    // db_query( 'DELETE FROM {users_roles} WHERE uid = %d', $user->uid );

    db_query('INSERT INTO {users_roles} (uid, rid) VALUES (%d, %d)', $user->uid, $rid);
  }
}

I have cross posted on the RR project, as I am not sure which maintainer should handle this. Any help would be greatly appreciated. Thanks!

Comments

#1

Posted by hunmonk on March 6, 2009 at 3:36am

Project:	LoginToboggan	» Registration role
Version:	5.x-1.3	» 5.x-1.x-dev

from logintoboggan_user_register_submit():

<?php
 $roles = isset($form_values['roles']) ? array_filter($form_values['roles']) : array(); 
?>

registration role should not be operating on the database directly, but rather on the form data. it's the job of user_save() to manage the saving of roles to the database.