Splitting this from #76725-43: Refactor project issue module to use Views (0): We need to re-implement My issues as a view.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 359131_issue_adv_search.3.patch | 10.39 KB | dww |
Splitting this from #76725-43: Refactor project issue module to use Views (0): We need to re-implement My issues as a view.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 359131_issue_adv_search.3.patch | 10.39 KB | dww |
Comments
Comment #1
dwwI started working on this with some input from merlinofchaos in IRC. However, we've quickly hit a fairly big design turning point, and I need feedback from the other project* maintainers (and interested parties from the d.o infra team) before I plow ahead one way or another...
In the D5--2 (and previous) codebase, when you enter text in the search box, the underlying code ends up doing this:
For the D6 version, to have a single exposed filter that does something like this, we have two options:
A) Write some gnarly custom filter handler to replicate the same SQL logic.
B) Implement the text search filter by means of the core search.module index (or equivalent on sites using something other than core search). Basically, we'd ship our default views for advanced search using the "Search: Search Terms" filter from core views + search, and if a site was using something other than core search, they'd replace this filter with something else (e.g. some kind of solr.views.inc etc).
Thoughts?
Comment #2
aclight commentedNot having the time now to inspect search.module to see how exactly it creates its index and all, how would the behavior a user sees with B be different from what we have today using our custom SQL?
One thing I don't like about how our advanced search works now is that, as far as I recall, if you put a phrase in quotation marks the search ignores them and still breaks the phrase into keywords on spaces. So a search for ' "project issue module" ' would give the same results as 'project issue module'. I don't know if core search handles this differently (and I could be wrong about this entirely), but if it did that would be nice.
Comment #3
dwwHere's an initial view just for project/issues/search. We'll need a different view for project/issues/search/% which has different fields and filters, but this is a start. It conditionally adds the exposed filter using the core search index depending on if search.module is enabled. Yes, it handles "only this" correctly, unlike our current SQL which indeed splits everything on whitespace.
One thing that'd be slick is if the issue queue links from the project column on this view went to project/issues/search/[uri] instead of just project/issues/[uri] -- if you're already advanced searching, and you click to drill down into a project, it'd be nice to remain in advanced search mode.
The UI of the exposed filters is also a mess -- that needs a bit o' theme lovin' to not look so horrible. ;)
Otherwise, this is pretty slick, and already much better than what we've got now.
Comment #4
dwwCommitted #3 and a per-project advanced search view to HEAD.
Setting back to active for:
A) Theme for the exposed filter form on these views
B) Adding filters for "Submitted by" and "Participant"C) Fixing the "Issue queue link" field handler to give a config option to link to the issue queue or advanced search queue for each project.D) Exposed filter for component should be multi-select list of all choices per-project, instead of a text search.E) Need an exposed filter for version that works the same way.Comment #5
dwwB) Committed a filter for "Submitted by" to both views in HEAD. Not sure how to make "Participant" work. :( Might want to punt that for now.
Comment #6
dwwCommitted a bunch of fixes for these to HEAD (and updated #4).
A) We might just punt, at least for now.
B) "Participant" depends on: #353002: "My recent posts" like in Drupal
C) Is fluff, that can come later...
Comment #7
dwwCommitted a fix for (C).
Comment #8
dwwNow that #353002: "My recent posts" like in Drupal landed, I just committed a "Participant" filter to both adv search default views.
All that remains now is (A), and that does seem worth doing (at least *something* to make it not so horrible).
Comment #9
gábor hojtsyNot any better then the live drupal.org, but not worse either. Removing the tag, so we can keep focus.
Comment #10
dwwI did some final cleanup of this before we went live. It's still not idea, but I think it's good enough to call this fixed. Other UI tweaks can happen in followup issues.