Closed (fixed)
Project:
Header image
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
15 Jan 2009 at 14:08 UTC
Updated:
5 Nov 2012 at 09:41 UTC
Jump to comment: Most recent file
Comments
Comment #1
benkewell commentedwell seems that the block cache holds the first version of the header image block after clearing the cache
and then showing it for every appearance of the header image block
resulting in a wrong header image being shown
Comment #2
thierry.beeckmans commentedWell, I haven't had the opportunity to try what I'm going to suggest, but I think it is the solution for this problem.
I've noticed elsewhere in drupal 6 that there's a possibility to set the caching method for a block, written like this: $blocks[$name]['cache'] = BLOCK_NO_CACHE;
We'll probably need to change the line it a bit so it works in this module.
Hopefully someone tries it this evening, I'm going to need this module tomorrow ;)
Comment #3
sittard commentedSame issue on our site with block cache enabled the image does not change.
Disable Block Cache and the problem is fixed.
Comment #4
redijedi commentedSame issue. Seems that this is a show stopper for sites that use caching.
Comment #5
thierry.beeckmans commentedI've added some code right after line 123
This should normally fix the caching problem.
Comment #6
Dracolyte commentedSubscribing. I'm having the same problem with some menu items. Question: Is there a way to selectively cache some blocks but not others in Drupal 6? (I'm using 6.10).
Comment #7
Dracolyte commentedThis module http://drupal.org/project/blockcache_alter looks promising in that it seems to allow block-by-block caching. Has anyone tried it in D6?
Comment #8
sutharsan commentedThe attached patch sets all Header Image blocks to be no-cache. More elegant solutions can be implemented in the future, but this solves the biggest problem.
Comment #9
brankoc commentedI tried the patch on about 10 sites (all very similar, and under development), and it works.
You suggest more elegant solutions: did you have something specific in mind? I am wondering what use-cases there could be where Headerimage-blocks need to be cached. If a person needs just a single static image at the top of every page, there are better ways to achieve that than using Headerimage.
http://api.drupal.org/api/constant/BLOCK_NO_CACHE/6 says to use this constant:
1. for simple blocks (notably those that do not perform any db query),
2. where querying the db cache would be more expensive than directly generating the content.
3. for blocks that change too frequently.
I believe #3 applies here.
Comment #10
sense-designDear fellow Drupal enthusiasts,
this issue is now lasting for a very long time in the issue queue and was unfortunately never solved. As Drupal is a open source project everyone is helping on voluntary basis. So that this is was not solved is nothing personal and means no harm. But perhaps no one had time to deal with this issue, maybe it is too complex or did not pose the problem comprehensible.
But this issue is not the only one. There are thousands of issues on Drupal.org that have never been worked on or could not be processed. This means that we are building a wave that is unmanageable and just a problem for the Drupal project as a whole. Please help us keep the issue queue smaller and more manageable.
Please read again, "Making an issue report" and see if you can improve the issue. Test the problem with the current Core and modules. Maybe the problem doesn't exist anymore, is a duplicate or has even been solved within this issue but never closed.
Help can also be found for it on IRC and in the user groups.
In order this issue no longer remains, I put this issue to "fixed".
If there is new information, please re-open the issue.