Closed (fixed)
Project:
MultiBlock
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
15 Jan 2009 at 14:08 UTC
Updated:
8 Feb 2009 at 01:40 UTC
Create an instance called "Who's Online 1", and this looks fine in the Instance page (Picture 3 attachment). However, on the block-list page, this appears as per Picture 4 attachment - with htmlencoding. Obviously, you can create a custom block on the normal block page, with the same format title, and it works fine (Picture 5 attachment).
| Comment | File | Size | Author |
|---|---|---|---|
| Picture 4.JPG | 28.07 KB | lyricnz | |
| Picture 3.JPG | 28.67 KB | lyricnz |
Comments
Comment #1
nancydruTry changing line 38 from
$list[$block->delta] = array('info' => check_plain($block->title));to
$list[$block->delta] = array('info' => $block->title);Block modules should have already escaped the titles before we get them back, and then we were escaping them again. Indeed if you look at "Who's Online" you will actually find ' in place if the quote.
I still need to look and see if we still need to escape the title when we create a new instance.
Comment #2
nancydru@Andrew: We don't need check_plain as the block.module is doing that at display time.
Comment #3
nancydruCommitted on both branches.
Comment #4
andrewlevine commentedNancy, thanks so much for keeping up with all these issues better than I can!
Comment #5
nancydruNo problem. Where should I send the invoice? :)
Comment #6
andrewlevine commentedhummmmmmm, you can try forwarding it to Bill:
Bill Gates
1835 73rd Ave NE
Medina, WA 98039
;)