External/Drupal plugins not loaded for second associated editor profile

Image Assist 6.x-2.x-dev (2008-Dec-28)

yes its all green in the updates screen

sorry for posting from my other user, i didnt realized it, anyway

heres some debug insight
in wysiwyg.module at line 320
this is where $plugin=='img_assist' as its set from img_assist.module line 1852
in wysiwyg.module it hits the next line on unset($info[$plugin]);
because theres no isset($profile->settings['buttons']['img_assist'])) setting in my $profile array
i do have however a 'drupalimage' member

      ["drupalimage"]=>
      array(1) {
        ["drupalimage"]=>
        int(1)
      }

if i comment out that unset above, the img_assist icon shows up ok in my tinymce..

how did i get a drupalimage instead of a img_assist member? guessing its some old name.. how can i fix it without breaking stuff?

thanks :-)

sorry for the late reply, it didnt but i didnt had time to test this more just did a quick workaround

disabling filter default had no effect, it doesnt have an entry in the uninstall tab so i just disabled it from the modules page
also cleared cache, cleared APC, logout/clear browser cache and cookies/login, new username - still no button
i have 2 other sites that exhibit the same issue but i dont really care on those, it was working before the update there too

i have this workaround in place

--- wysiwyg/wysiwyg.module_orig.module  2009-01-17 14:14:21.000000000 +0000
+++ wysiwyg/wysiwyg.module_new.module   2009-02-02 00:32:00.000000000 +0000
@@ -317,7 +317,7 @@ function wysiwyg_add_plugin_settings($pr
     // Only keep enabled plugins in this profile.
     foreach ($info as $plugin => $meta) {
       if (!isset($profile->settings['buttons'][$plugin])) {
-        unset($info[$plugin]);
+//        unset($info[$plugin]);
       }
     }

im still up to date with the latest versions of the modules im using above
i think the key is in #5 post here, i cant figure it out though because i have no idea about the code and no time to dig for now.. but its weird that i seem to be the only one with this issue, probably something related to the local modules im using or some update cycle (maybe missed some update and updated directly to the next one..)

another thing to note
if i enable img_assist on the filtered html wysiwyg profile (tied to the filtered input format), then the button shows up for both filtered and editor profile
if i disable it on the editor profile then it just appears on the filtered profile (my editor wysiwyg prrofile is tied up to the editor input format and editor role, shows up only to users with that role..)
in these cases (img_assist enabled on filtered), switching input formats when editing works ok (button show or hides depending on settings)

if i disable img_assist on the filtered profile back, then it wont show up anymore for both filtered and editor... any idea?

#11 was a fix and #16 is the fix reverted because it screwed up some other things? did i understand this correctly? with the latest versions today im still having the original problem

ive looked through this issue again, with the latest version and referring to wysiwyg/wysiwyg.module, to the best of my understanding the problem is:
- line 115 : this forms api hook steps through the input formats that get displayed on a page
- line 128 : for the first input filter in the form (which is Filtered HTML for me) it calls wysiwyg_add_plugin_settings()
- line 365 : this function will walk through the enabled modules (?) for the current editor (and since i dont have img_assist enabled for Filtered HTML), and disable any modules not enabled for _this_ input filter, even though its not the default and active one

so the fix comes naturally in checking if the input filter passed on to wysiwyg_add_plugin_settings() is also the one selected by default, if its not, then do not disable any plugins that arent in its list, do that just for the default one..

heres the patch, it works ok for me but ill test it more tomorrow (and will write about any issues..) since its almost morning and i need some sleep :-)

--- wysiwyg/wysiwyg.module_orig 2009-03-06 05:22:48.000000000 +0200
+++ wysiwyg/wysiwyg.module_new   2009-05-10 10:54:41.000000000 +0300
@@ -125,7 +125,7 @@ function wysiwyg_process_form(&$form) {
               $theme = wysiwyg_get_editor_themes($profile, (isset($profile->settings['theme']) ? $profile->settings['theme'] : ''));

               // Add plugin settings (first) for this input format.
-              wysiwyg_add_plugin_settings($profile);
+              wysiwyg_add_plugin_settings($profile, $element[$format]['#default_value'] == $element[$format]['#return_value']);
               // Add profile settings for this input format.
               wysiwyg_add_editor_settings($profile, $theme);
             }
@@ -335,7 +335,7 @@ function wysiwyg_add_editor_settings($pr
  *   profiles in use, so we can process plugins in multiple profiles in one shot
  *   and simplify this entire function.
  */
-function wysiwyg_add_plugin_settings($profile) {
+function wysiwyg_add_plugin_settings($profile, $is_default) {
   static $plugins_native = array();
   static $processed_formats = array();

@@ -361,7 +361,7 @@ function wysiwyg_add_plugin_settings($pr
   }
   // Only keep native external plugins that are enabled in this profile.
   foreach ($plugins_native[$editor['name']] as $plugin => $meta) {
-    if (!isset($profile->settings['buttons'][$plugin])) {
+    if ($is_default && !isset($profile->settings['buttons'][$plugin])) {
       unset($plugins_native[$editor['name']][$plugin]);
     }
   }

do i also need to re-open the issue ? if im wrong, please excuse my lack of knowledge on drupal issue handling