This part of code at the end of hook_user is run for every $op. Thus in all cases where $op != "login", $url is undefined.

  if (login_destination_apply_redirect()) {
    $_REQUEST['destination'] = $url;
  }

I'm attaching a patch which sets $url = '' at the beginning of the function. The other solution is to move the code above inside the switch. I'll leave it up to developers to decide the approach, as I'm not sure about the module inner workings and if such move would break something else.

Also fixing another notice for undefined variable.

CommentFileSizeAuthor
various_notices.patch1.05 KBflevour

Comments

Bastlynn’s picture

Status: Active » Closed (won't fix)

I believe this has been fixed since this was noted over 2 years ago. If not please open a new request and reroll a patch against D7, since that's where we're trying to move this module at this point.