biblio_show_results broken

vrabaud - January 16, 2009 - 12:49
Project:Bibliography Module
Version:HEAD
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

Hi, it seems that in biblio_show_results, $inline=='profile' returns true when $inline = true. Therefore, one needs to make sure that $inline is also a string in that test.

Thx for your great work !

Regards

AttachmentSize
brokenShow.patch455 bytes

#1

rjerome - January 16, 2009 - 17:19

Thanks, could you try just putting a triple equals sign instead i.e.


if ($inline === 'profile') {

should accomplish the same as

if ( (is_string($inline)) && ($inline == 'profile') ) {

#2

vrabaud - January 16, 2009 - 19:14

ok, that fixes it too for me. Thx !

#3

rjerome - January 16, 2009 - 20:17
Status:active» fixed

Ok, I'm going to go with that solution then.

#4

System Message - January 30, 2009 - 20:20
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.