I have a custom module that I'm working on, and I'm finding the ddblock configuration settings appearing in the block configuration page for my custom module's block.

I only have one ddblock, and it to has a a delta value of 2 in the db.

My custom module provides 3 blocks with deltas 0, 1 & 2. The ddblock configuration settings only get injected into my block with a delta value of 2.

CommentFileSizeAuthor
#2 ddblock-fix-ddblock-config-issue-359810-1.patch653 bytesppblaauw

Comments

mrfelton’s picture

mrfelton commented

Just to confirm that this problem is not specific to my custom module. It happens for any block which has a delta value equal to that of a ddblock block. I tested with the tagadelic module, which also creates a block with $delta=2, and the ddblock settings indeed do get injected into the config page for that block too (at admin/build/block/configure/tagadelic/2)

ppblaauw’s picture

ppblaauw commented
Status: Active » Needs review
StatusFileSize
new ddblock-fix-ddblock-config-issue-359810-1.patch653 bytes

Thanks for reporting.

This patch should prevent ddblock configuration settings in non dynamic display block blocks.

Please let me know if this solves the issue.

mrfelton’s picture

mrfelton commented
Status: Needs review » Reviewed & tested by the community

fixed. Thanks.

ppblaauw’s picture

ppblaauw commented
Status: Reviewed & tested by the community » Fixed

Tom, thank you for testing.

Set status to fixed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.