When trying to revert a view back to its default state, the confirmation button should read 'revert' and not 'delete'.

Comments

merlinofchaos’s picture

Status: Active » Fixed

Fixed in CVS. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

austintnacious’s picture

Version: 6.x-2.2 » 6.x-2.9
Category: bug » feature
Status: Closed (fixed) » Needs review

No way!!!

I "reverted" a view late the other night, thinking as would anybody (I think) that I was reverting back to my previously saved state; just like "revert" in EVERY other program out there. As far as I know there is no program which wipes a users work completely back to a blank slate when the user clicks revert, except Views, apparently.

And one would assume that if that was indeed about to happen the warning would say scream something like "do you really want to wipe out ALL of the work you've been doing for the past couple of hours?"

THAT BUTTON SHOULD AND NEEDS TO SAY "DELETE"!

Honestly, who does read ALL of the fine print as they go through life, get busy, frustrated, tired, confused, distracted. . . if a button. . . why is the Effing thing even on the views edit page, why is it anywhere near "Save" and "Cancel". . .

"Revert" = go back to a previously saved state
"Reset to Defaults" = reset to default configuration, factory settings, whatever
"Delete" = DELETE!

merlinofchaos’s picture

Version: 6.x-2.9 » 6.x-2.2
Category: feature » bug
Status: Needs review » Closed (fixed)

Revert does revert to a previous saved state. It is the state that the view was exported to in code. It is not the last time you saved, for example. Yes, if you 'revert' you ARE going to lose the last "couple hours" of work, or whatever it has been since you exported.

The text for this is pretty clear I think:

    $title = t('Are you sure you want to revert the view %name?', array('%name' => $view->name));
    $desc = t('Reverting the view will delete the view that is in the database, reverting it to the original default view. Any changes you have made will be lost and cannot be recovered.');
    $button = t('Revert');

Finally, it's not ok to hijack an older issue just to vent. Resetting original values.