Forcing links to be opened in a new window is bad for usability. Users should decide for themselves if they want to open the link in the existing window or in a new one, by clicking the middle mouse button, for instance. Therefore I suggest removing this feature from ELF. I would like your opinions on this.

Comments

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

By the way: this would be for version 3. Version 2 stays the way it is.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Version: 5.x-2.0 » 5.x-3.x-dev
yoroy’s picture

yoroy commented

Agreed. always let the visitor decide for herself where a new link should be opened.

BTW, one of the best rants against (wrongly implemented) popups is here: http://youngpup.net/archived/popups.html

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Assigned: Unassigned » xano
Status: Active » Fixed

Removed and committed.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Why not leave this functionality in but just defaulted to OFF? There are some situations where the client wants it to work that way.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

Since your client should not decide how his visitors browse his site. If those visitors want to open those links in a new window, they can do so themselves.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

Here's some more documentation on why forcing new windows is bad.

andrewsuth’s picture

andrewsuth commented
Version: 5.x-3.x-dev » 6.x-2.x-dev
Component: User interface » Code

EDIT: Comment moved to http://drupal.org/node/521900#comment-1869728

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Component: Miscellaneous » User interface
Priority: Critical » Normal

I think you posted this comment in the wrong queue.

Standart’s picture

Standart commented
Version: 6.x-2.x-dev » 5.x-3.x-dev
Component: Code » User interface
Status: Closed (fixed) » Active

Let the user choose. I, as someone who builds website, use this module and want to decide how external links behave. I'm also for keeping (re-adding) the functionality and setting the default to OFF.

Whatever reason to let external links open a new window, this is the only way to do it in a standards-compliant way.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Active » Fixed

This feature has been added again with the release of version 6.x-3.x-dev. I do recommend you use it with caution and only if your boss will go berserk.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Thank you for adding it back again.

andrenoronha’s picture

andrenoronha commented

i installed the module, enabled the option to open links in a new window
but i dont see anything...
nothing changed... no icons, no css classes, no links in a new window

i use contemplate and a cck field.
what am I missing?
i'm using elf-6.x-2.1

how can drupal recognize an external link??

thanks...

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

As the project page explains ELF provides an input filter, which are not applied to CCK fields. Also see #238901: Support for CCK link fields.

andrenoronha’s picture

andrenoronha commented

thanks but i'm using External Links Module... It works fine for me.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Assigned: xano » Unassigned