Download & Extend
Browscap » Issues

PHP Notice: Trying to get property of non-object

Posted by kenorb on January 17, 2009 at 9:26pm
Project:Browscap
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

This can be improved:

// $Id: browscap.module,v 1.6.2.3.2.4 2008/08/13 02:49:43 robloach Exp $
PHP Notice:  Trying to get property of non-object in /home/sites/co.uk/public_html/sites/all/modules/contributions/browscap/browscap.module on line 257
PHP Notice:  Trying to get property of non-object in /home/sites/co.uk/public_html/sites/all/modules/contributions/browscap/browscap.module on line 259
PHP Notice:  Undefined index:  parent in /home/sites/co.uk/public_html/sites/all/modules/contributions/browscap/browscap.module on line 90
PHP Notice:  Undefined index:  crawler in /home/sites/co.uk/public_html/sites/all/modules/contributions/browscap/browscap.module on line 95
Login or register to post comments

Comments

#1

Posted by VM on May 18, 2009 at 5:37am

similar report #410114: PHP Notices: "Trying to get property of non-object" and "Undefined index"

#2

Posted by VM on May 18, 2009 at 5:38am
Category:feature request» task

#3

Posted by Rob Loach on June 8, 2009 at 11:48am
Status:active» needs review
AttachmentSize
blah.patch 2.65 KB

#5

Posted by VM on June 8, 2009 at 5:58pm
Title:Trying to get property of non-object» PHP Notice: Trying to get property of non-object
Category:task» bug report

#6

Posted by greggles on September 16, 2009 at 10:48pm

Here's the same patch merged with some other php notices I found.

However, I was never able to reproduce the original issue here. What are the steps to repeat?

AttachmentSize
360347_6_browscap_notices.patch 3.77 KB

#7

Posted by greggles on September 17, 2009 at 3:05pm
Status:needs review» fixed

I looked at the code some more and it seems reasonable - http://drupal.org/cvs?commit=264084

(Also, I didn't want to have to merge a bunch of stuff as I work on other patches ;) )

#8

Posted by System Message on October 1, 2009 at 3:10pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.