Hi there,
today I updated a site that uses Drupal 6 since ther was a possible security issue with the version it was running. While I was at it, i also upgradd ThemeKey which is required by Taxonomy Menu. Since I only installed themekey as a required module, i hardly knows what it does.
But that's not the point, after upgrading I received a warning on all my pages when logged in stating

__clone method called on non-object in /var/www/html/rick/includes/common.inc on line 1685.

Which I could trace down to a call of ThemeKey on line 147 to drupal_clone().
I 'fixed' this (really, i have no idea what i'm doing ;-) ) by changing line 146 from:

if (isset($object)) {

into:

if (isset($object) && is_object($object)) {

apparently one time the match_properties gets called with something not being an object. Maybe from taxonomy mnu, may from inside ThemeKey.

Cheers
Appie Verschoor

CommentFileSizeAuthor
#15 Themekey-problem.jpg48.17 KBmsoltan

Comments

chrissearle’s picture

chrissearle commented

subscribe

profix898’s picture

profix898 commented

I just looked at Taxonomy Menu and I coulnt find any dependency of that module on themekey. Also the latest version of themekey (Jan 09) is incompatible with the earlier development versions as it introduces namespaces for all properties, such as 'taxonomy:tid' instead of just 'tid', etc. In principle, that would break all modules using the previous syntax. But again, I couldnt find any dependency in Taxonomy Menu!

chrissearle’s picture

chrissearle commented

I don't have taxonomy menu installed - but I did have taxonomy theme. And I still get the error.

profix898’s picture

profix898 commented

@chrissearle: There was a bug in taxonomy theme causing malformed entries being added for the properties section of themekey. You should 1. visit the settings page of themekey and submit it (what rebuilds indices, etc.) and 2. remove malformed row from themekey_properties table. Or just reinstall themekey to recreate the database tables. I guess that you are still having incompatible and/or malformed items in your themekey_* tables generated by taxonomy theme or the previous version of themekey.

chrissearle’s picture

chrissearle commented

I'll give that a test - thanks

chrissearle’s picture

chrissearle commented

Hmm - tried an uninstall (modules > uninstall) and then re-enabled themekey and tax. theme. Now I get

Either 'Taxonomy: Term (tid)' or 'Taxonomy: Vocabulary (vid)' is not enabled!
Please visit the ThemeKey settings page and select both of these properties.

Only issue is - under settings two things are checked

taxonomy:tid	Taxonomy: Term	
taxonomy:vid	Taxonomy: Vocabulary

However - the clone error message is gone.

profix898’s picture

profix898 commented

@chrissearle: You must update taxonomy_theme to the latest version as well ;)

chrissearle’s picture

chrissearle commented

Update Status report is saying that tax. theme is 6.x-1.x-dev (2008-Jun-15) and up to date. 2008-Jun-15 is also the date I see on the project page ?

profix898’s picture

profix898 commented

Hmm, thats strange. The changes are in CVS and if you download the latest development snapshot you also get the latest revisions. But for some reason the changes are not reflected on the project page and in 'update_status'.
I just filed a bug report to the infrastructure queue. So this will hopefully be fixed shortly.

robbertnl’s picture

robbertnl commented

Same problem here with Drupal 6.9 & ThemeKey 6.x-1.0.
Reverting to ThemeKey 6.x-1.x-dev till this problem has been fixed.

rightchoice2c_me’s picture

rightchoice2c_me commented

@xiffy
I got the same error when I upgraded themekey but I solved this error by just resaving configurations for themekey.

robbertnl’s picture

robbertnl commented

Just resaving the theme settings didnt work for me.
Fixed by disabling 'Provide all themes for selection'

btopro’s picture

btopro commented

Fixed posted in the original post got this working again for me (good catch)

profix898’s picture

profix898 commented
Status: Active » Closed (fixed)

I hope everyone was able to migrate to a stable 6.x-1.0+ version by now.
The is_object() problem mentioned in the original post should be fixed in latest CVS version (and coming 6.x-1.1 release).

msoltan’s picture

msoltan commented
StatusFileSize
new Themekey-problem.jpg48.17 KB

I installed Themekey module in my localsite and it works well, but when I Uploaded it to server i found my site Became offline mode and made a painstaking effort to uninstalle this module again, so now I am in dire need of it..
Have you found one of these problem and what is resolved

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented

Please do not post in closed issues!

BTW ThemeKey 6.x-1.x isn't supported anymore.

If you have a question open a NEW support request and provide detailed information: Drupal version, ThemeKey version ...