Bad curl_setopt() when open_basedir restriction is in effect.

And my PHP version is 5.2.6-2ubuntu4.

Help!!!

Thanks,

I don't think I have to do more than dump the curl_exec return. It always return "1" in the file. When looking at PHP doc we ca see, for curl_exec:

Return Values

Returns TRUE on success or FALSE on failure. However, if the CURLOPT_RETURNTRANSFER option is set, it will return the result on success, FALSE on failure.

So it looks like my curl_exec() returns only TRUE, so I looked in drupal_web_test_case.php for this magic option and found:

  protected function curlConnect() {
    global $base_url, $db_prefix;
    if (!isset($this->ch)) {
      $this->ch = curl_init();
      $curl_options = $this->curl_options + array(
        CURLOPT_COOKIEJAR => $this->cookie_file,
        CURLOPT_URL => $base_url,
        CURLOPT_FOLLOWLOCATION => TRUE,
        CURLOPT_RETURNTRANSFER => TRUE,
        CURLOPT_SSL_VERIFYPEER => FALSE,
        CURLOPT_SSL_VERIFYHOST => FALSE,
        CURLOPT_HEADERFUNCTION => array($this, 'curlHeaderCallback'),
      );
      if (preg_match('/simpletest\d+/', $db_prefix)) {
        $curl_options[CURLOPT_USERAGENT] = $db_prefix;
      }
      if (!isset($curl_options[CURLOPT_USERPWD]) && ($auth = variable_get('simpletest_httpauth_username', ''))) {
        if ($pass = variable_get('simpletest_httpauth_pass', '')) {
          $auth .= ':' . $pass;
        }
        $curl_options[CURLOPT_USERPWD] = $auth;
      }
      curl_setopt_array($this->ch, $this->curl_options + $curl_options);
    }
  }

So, I did:

  protected function curlConnect() {
    global $base_url, $db_prefix;
    if (!isset($this->ch)) {
      $this->ch = curl_init();

      ...

      $this->assertTrue(TRUE, "Curl options has been set!");
    }
    else {
      $this->assertTrue(FALSE, "Curl options not set..");
    }
    $this->assertTrue(TRUE, "Making curlConnect");
  }

And, it's OK, my simpletest inits the curl_options, I have the assert TRUE the first call, then none the followings (which is normal because curl_options are inited only once).

I'm still looking, but I think this could be a broken curl on Ubuntu 8.10, what do you think ?

PS: In this method, we can see this:

$curl_options = $this->curl_options + array(

And then, some lines later, this is done:

curl_setopt_array($this->ch, $this->curl_options + $curl_options);

Is this a nonsens ? the $this->curl_options parameter is concatened twice with $curl_options? And thus, the first time, as the first element before the operator is $this->curl_options, if this object attributes carry the option CURLOPT_RETURNTRANSFER to FALSE, the setting won't be override.

And found an error!!!

When you do this:

  function drupalGet($path, $options = array()) {
    $options['absolute'] = TRUE;

    // We re-using a CURL connection here.  If that connection still has certain
    // options set, it might change the GET into a POST.  Make sure we clear out
    // previous options.
    $out = $this->curlExec(array(CURLOPT_HTTPGET => TRUE, CURLOPT_URL => url($path, $options)));
    $this->refreshVariables(); // Ensure that any changes to variables in the other thread are picked up.

    // Replace original page output with new output from redirected page(s).
    if (($new = $this->checkForMetaRefresh())) {
      $out = $new;
    }
    return $out;
  }

The CURLOPT_RETURNTRANSFER is not set! And the curlExec() function won't init it! Because in the init method I described higher, the $this->curl_options is never modified!!!

So, I had this:

- $out = $this->curlExec(array(CURLOPT_HTTPGET => TRUE, CURLOPT_URL => url($path, $options)));
+ $out = $this->curlExec(array(CURLOPT_RETURNTRANSFER => TRUE, CURLOPT_HTTPGET => TRUE, CURLOPT_URL => url($path, $options)));

And that works (I don't have my firefox freezing anymore!) Yay! But tests still won't pass.

But, that's better, my curl_exec now have a return when using the drupalGet() method.

I think this CURL_RETURNTRANSFER thing should be per default?

When I look at your code, the $this->ch is inited only once in curlConnect() method, and curl_setopt_array() is called with the good options the first time, so I can't figure it out why, but when it pass through the drupalGet() method, in my environement, it seems that the curl options have been erased somewhere, and the the CURL_RETURNTRANSFERT is not present anymore. Where it's bad is this should be set into the $this->curl_options, right? (Well I still doubt about that because in curlConnect() method $this->curl_options is used, to concatenate with new options, but never write back with those).

curl_setopt can not set the CURLOPT_FOLLOWLOCATION option when open_basedir is in effectn see those two:

• http://php.net/manual/en/function.curl-setopt.php#71313
• http://www.php.net/manual/en/function.curl-setopt.php#85580

(thanks chx).

A workaround may be done in curlExec() method (http://www.php.net/manual/en/function.curl-setopt.php#85580).

Good question, only saw the bug on D6 (did not tested D7).
But, this is a CURL related bug, not only Drupal's, so it has good chances to be in D7.