Download & Extend
Project Issue File Review » Issues

TODO

Posted by boombatower on January 18, 2009 at 1:53am
Project:Project Issue File Review
Version:6.x-2.x-dev
Component:Miscellaneous
Category:task
Priority:normal
Assigned:boombatower
Status:closed (fixed)

Issue Summary

--

Login or register to post comments

Comments

#1

Posted by boombatower on January 19, 2009 at 10:09am

These are TODO items that are more detailed then the general ideas found in my blog summary. I'm keeping track of these as I come up with them.

  • Create common style sheet? with red, green colors. (DONE)
  • Keep track of the total number of patch runs each client has run. (DONE)
  • Client event log. (DONE)
  • Check URL on client for (current method doesn't seem to work). (DONE)

#2

Posted by boombatower on January 18, 2009 at 7:02am

Deal with this in pifr_client install.

<?php
function pifr_settings_form_submit($form, &$form_state) {
  menu_rebuild();

  if ($form_state['values']['pifr_role'][PIFR_SERVER_SLAVE]) {
    $checkout = file_directory_path() . '/checkout';
    $review = file_directory_path() . '/review';
    file_check_directory($checkout, TRUE);
    file_check_directory($review, TRUE);

    // TODO Deal with symbolic link.
  }
  else {
    // TODO Properly remove checkout.

    if (file_exists(file_directory_path() . '/review')) {
      rmdir(file_directory_path() . '/review');
    }
  }
}
?>

Moved to: #369464: Client installer needs to create directories and such

#3

Posted by boombatower on January 18, 2009 at 7:50am

(DONE)

Add settings to client.

<?php
$form['test_master']['pifr_test_timeout'] = array(
      '#type' => 'textfield',
      '#title' => t('Testing timeout'),
      '#description' => t('The maximum time, in minutes, allowed to testing slaves until they are automatically reset.'),
      '#size' => 4,
      '#default_value' => variable_get('pifr_test_timeout', 45)
    );
?>

and information about server and client key.

#4

Posted by boombatower on February 5, 2009 at 5:24am
Status:active» fixed

#5

Posted by System Message on February 19, 2009 at 5:30am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here