Download & Extend

Nodes with no Flash uploaded still displays the object code

Project:FlashField
Version:6.x-0.0
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:needs review

Issue Summary

When a flashfield is enabled on a node, and no flash is uploaded, the object code looks like this

<div class="flashnode">
<object width="849" height="192" classid="clsid:D27CDB6E-AE6D-11cf-96B8-444553540000">
<param value="http://localhost/ef/sites/test.com/files/" name="movie"/>
<param value="7" name="version"/>
<param value="true" name="play"/>
<param value="true" name="loop"/>
<param value="false" name="menu"/>
<param value="false" name="allowfullscreen"/>
<param value="#FFFFFF" name="bgcolor"/>
<param value="false" name="swliveconnect"/>
<param value="http://localhost/ef/sites/test.com/files/" name="base"/>
<object width="849" height="192" data="http://localhost/ef/sites/test.com/files/" type="application/x-shockwave-flash">
</object>
</object>
</div>

Shouldn't this object just be ignored and not returned?

I have a patch that checks if the file exists, and if it doesn't it will just return.

Comments

#1

Here is the patch.

AttachmentSize
flashfield.360522.patch 792 bytes

#2

rerolled. My first one was busted.

AttachmentSize
flashfield.360522_1.patch 724 bytes

#3

Hi,

This patch works indeed but i'm afraid it's not complete because when a movie is wrapped in a fieldset, the fieldset is still shown.
Is this patch-able too or is this a problem?

Grtzzz,
Hatznie.

nobody click here