Notify 5.x-1.2 upgrade cleared the setting for notification and they will not stick when re-entered.
Warning box: Your e-mail address must be specified on your my account page.

Each account does have an email.
Clicking submit comes back with all settings removed and a statement that the settings have been saved.
It cleared all user's settings. I have re-entered the emails, I have run cron. No change.

Anyone else seeing this?

Comments

NaX’s picture

NaX commented
Priority: Normal » Critical
Status: Active » Needs review

I have just done a clean install and on the root account I got this message. After a few min of investigating the code I found the problem.
The problem is notify_user_settings_form() is referring to $arg->uid and the passed in arg is $uid or you could also use arg(1).

This

function notify_user_settings_form($uid = 0) {
  global $user;
  if ($user->uid != $arg->uid && $user->uid != 1) {
    drupal_access_denied();
    return;
  }
  
  $account = user_load(array('uid' => $arg->uid));

Should be this:

function notify_user_settings_form($uid = 0) {
  global $user;
  if ($user->uid != $uid && $user->uid != 1) {
    drupal_access_denied();
    return;
  }
  
  $account = user_load(array('uid' => $uid));
peregrine’s picture

peregrine commented

Thanks for the fast response. Working fine now.

Standart’s picture

Standart commented

Seems to be working for me, too. Thanks.

JoachimVdH’s picture

JoachimVdH commented

works 4 me too. Tnx

sdrycroft’s picture

sdrycroft commented

I was just about to submit a patch of exactly this. It really should be packaged up into 5.x-1.3.

matt2000’s picture

matt2000 commented
Status: Needs review » Fixed

This has been fixed in dev for a while. I just rolled a new release.

sdrycroft’s picture

sdrycroft commented

Cheers Matt.

Simon

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.