The modules replaces non A elements aswell.
So if i have for example http://www.mydomain.com without it being a "A" element in my content it will add the tags aswell.
Thus showing a really long tagged url in the content :)
Correct me if im wrong but would it not be better when it replaces only A elements?
Regards
Comments
Comment #1
sutharsan commentedThis would be better, but in HTML emails only.
Anyone want to write this? Requires knowledge of regular expressions.
Notes: The email format is found in $message. The replacement takes place in _simplenews_analytics_parse_body().
Comment #2
catofcheshir commentedOne more problem. I use insert_view module for automatically insert links to new posts on my site. Insert_view makes replacement as filter, and replaced text seems to be invisible to Simplenews Analytics. My views produse teasers, all links from titles to nodes is not rewritten. But - hey! - images in nodes has "?utm_source=..." part.
Can i get all links to be rewritten?
Comment #3
sutharsan commentedcatofcheshir I like you to try a few things:
1. replace the view with its html. Take an existing newsletter with a view, copy the newsletter's html and past it into a new newsletter. Are the links rewritten now?
2. Copy a few samples of the links which are not rewritten in this issue. Make sure you copy some surrounding html too, since that may be the cause of the problem.
Comment #4
catofcheshir commentedThis is not rewritten:
Maybe because lots of style, title and other stuff? I'm using Mime Mail CSS Combiner to embed styles.
Comment #5
tfranz commentedI have the same problem with insert_views – some links won't be modified ...
This is the code copied out of the newsletter:
If i paste this back in the body of a new newsletter, all links will be modified as expected ...
Any help or hint?
Thank you!
Tobias
Comment #6
sutharsan commentedCopy the same data not from the email but from the node. This is what Simplenews Analytics works with.
Comment #7
tfranz commentedThere is no data in the node, because the view is embedded inside my custom template of simplenews "simplenews-newsletter-body.tpl.php":
The problems are inside the embedded views – some links inside the views will be recognized by Simplenews Analytics, some not ...
(By the way: ... for me it's not a real problem, because this time i can rewrite all links inside the views "by hand" – but it would be nice to have if it would work in future cases ... :-)
Thank you very much!
Comment #8
sutharsan commentedtfranz, since you know your way around the code, please print the content of the view to the screen and copy some good and some failing links for the html source. We are looking for a pattern which is not recognized as a link by simplenews_analytics. Do something like this in simplenews_analytics.module:
Comment #9
djschoone commentedI also do have this issue with the embed view. Could it be that links are being filtered AFTER this module replaced the link?
Comment #10
Alienpruts commentedSetting to closed, 5 years old
Comment #11
llribas commentedI'm still fighting with this issue, the module inserts the the analytics parameters in image urls but not in the title links (from insert-views, both titles with
<a>links and images)