Closed (fixed)
Project:
Quick Tabs
Version:
6.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
19 Jan 2009 at 17:29 UTC
Updated:
23 Dec 2014 at 20:42 UTC
Jump to comment: Most recent
Comments
Comment #1
EkaMei commentedThat request seem to defeat the purpose of quick tab entirely, if they become a link when clicking, why not just use a dynamic link module instead?
Comment #2
bsod commentedBecause I need to change only one tab in quicktab block into dynamic link, so it will look like this:
__|tab1(latest articles)|__|tab2(popular articles)|__|tab3(link to node/add/article)|__
Comment #3
pasqualle@bsod: As I understand you want some tabs to work as tabs, and some as page links. Can you give a specific example how would you use that feature? If you put the page links into the tab content that would not be as useful?
Comment #4
pasqualleok, I crossposted. The example is good
Comment #5
pasqualleI think such feature directly supported by the module is outside of its functionality.
You can override the theme_quicktabs_tabs() theme function to add any other link to it. I would like to see some theme template files for quicktabs to make such changes easier in the future..
Comment #6
bsod commentedThanks, I will try this solution.
It would be nice if user can also put qt block title or any plain text before tabs, in the same line, so it will look like this:
__Articles:__|tab1(latest articles)|__|tab2(popular articles)|__|tab3(link to node/add/article)|__
Comment #7
pasqualleYes, that also can be done with theming.
I change this to feature request as there is no QT issue about theme templates and make theming easier..
Comment #8
bsod commentedAs my knowledge about theming via theme functions is poor I'll be very thankful if you could give me more specific example how such theme function should look.
Comment #9
pasqualleIn the theme template.php file you can create a MyThemeName_quicktabs_tabs() function where you copy the code from theme_quicktabs_tabs() and change it as you like.
This code should work with garland (but I did not tested), and it contains your required changes with a "+" sign at the line start (you need to delete the + sign). Also this will change all quicktabs, so you will may have to use some "if" statements where required.
Comment #10
EkaMei commentedThis would probably be best suitable for an addition option in adding quick tap, beside adding a block, node, and another QT, it should have an additional choice to add a simple link to the tab itself.
At first I was a little skeptical, but this is indeed a very good feature suggestion!
Comment #11
bsod commented@Pasqualle, everything works great except link tab which works like a qtab not like a link.
Comment #12
pasqualle@bsod: you are right. Every link inside
<li>is turned into qtab link because of the javascript in QT. If you change it tothen it works as a link, but it results in invalid HTML..
Maybe some modifications will be needed in the js also, to support good QT templates.
@EkaMei: I am not convinced that QT should support "quick tap". That would require serious rethink of the QT source code, because all other types change the tab content, not the tab link. With theme template files more extreme ideas can be achieved easily..
Comment #13
EkaMei commentedThat is true, I can see few scenario where this will work well, but it might not be worth the hassle
Comment #14
pasqualleMoving new features to 3.x version
Comment #15
brianmercer commentedHas anyone created a quicktabs.tpl.php?
I just want to add "clear-block" to the classes for quicktabs_wrapper, quicktabs_tabs and quicktabs_main. Has anyone converted quicktabs_render to a preprocess and tpl.php?
Comment #16
pasqualle@brianmercer: no, there is no theme template file support in QT yet.
Comment #17
jenlamptonIt would also be great if the markup from quicktabs_render could be moved into a theme function, or template file.
I needed to add a clearfix in order to make the "basic" tab style work with a grid-style table view, and had to patch edit the .module file to get that to happen. :(
(For those of you curious how to make this happen, it's line 245, prepend a clearing div before the two closing div tags, like so:)
Comment #18
netw3rker commented