Support for different text groups
Jose Reyero - January 19, 2009 - 18:53
| Project: | Localization client |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs review |
Description
This adds a textgroup parameter everywhere so other modules can add strings to the list and have them in the right text group (other than 'default').
The patch is simple though it needs to add the field everywhere:
- Textgroup parameter for l10_client_add_string_to_page()
- This makes the strings array indexed by textgroup and source
- Adds this new field in _l10n_client_dom_strings()
- Two lines of javascript to have the value submitted.
My use case is i18n module (which adds strings to l10n client's list) but for different text groups. With this one, l10n client can work with i18n (i18nstrings) to translate user defined strings. This is related to: #287210: Some new features ported from 5.x version
| Attachment | Size |
|---|---|
| l10n_client_i18n_d6.patch | 5.67 KB |
#1
#2
Patch still worked, but didn't apply cleanly anymore.. so here's a new version for l10_client-6.x-1.7.
#3
subscribing...
#4
Hi folks,
just added another change - cause there was some problem with passing on the real textgroup instead of the default 'default'.
enjoy!
#5
The patch in #4 doesn't apply cleanly (and doesn't apply completely on my machine). Attached is the same patch, rerolled against the latest version.
I think this patch still needs work because it has some pretty serious usability issues for translators. The main issue being that non-default sources are listed twice, without any visual indicator as to which text group they are in. If the translator only translates one of them, the translations for the given string are in a hit-and-miss sort of state.
#6
Is there a reason why the groups have to be separated?
I'd like to see them all in the same list, to keep things very simple.
#7
in case of collision of words, such as 'associate' noun or verb.
Also view http://drupal.org/node/307338