Well, I decided to use Drupal 6.x to create an auction site where users can sell stuff.

Two problems I've run across so far:

In uc_auction_form_alter() when creating an auction with "all products are auctions" checked the start bid price field is disabled. I changed the $is_auction to TRUE, but it appears that on the node create it doesn't pass this value in. Once the node is created and I go back to edit it I can put in the start bid price and it works. I'll look into this further.

The second problem lies on the user->active auctions page. Even when the user is the high bidder it still shows no. The fix for this was to modify the $node->uc_auction['high_bidder'] on line 40 in uc_auction.user.inc to $node->uc_auction['high_bid_uid'].

Great module guys! I tried working with the ecommerce, but it's nothing compared to ubercart :-).

I'll be working on bug fixes for this module as I need to have the site up very soon, and I'll post solutions to my problems for everyone to benefit from.

Comments

andrewoke’s picture

andrewoke commented

One last thing I can't figure out:

<form action="/daylily6/?q=node/7" accept-charset="UTF-8" method="post" id="uc-catalog-buy-it-now-form-7">
<div><input name="nid" id="edit-nid-2" value="7" type="hidden">
<input name="op" id="edit-submit-7" value="Add to cart" class="form-submit list-add-to-cart" type="submit">
<input name="form_build_id" id="form-20fc357604fab1929cfab26127ad00b9" value="form-20fc357604fab1929cfab26127ad00b9" type="hidden">
<input name="form_token" id="edit-uc-catalog-buy-it-now-form-7-form-token" value="93ad41adf6740dfd5cf13cdfbca7ef61" type="hidden">

<input name="form_id" id="edit-uc-catalog-buy-it-now-form-7" value="uc_catalog_buy_it_now_form_7" type="hidden">

</div></form>

No idea where this is coming from... help would be appreciated. It's showing up in auctions when they are still active.

andrewoke’s picture

andrewoke commented

You guys might start to hate me for all the posts, but I found very dirty fix for the buy now. The uc_auction_add_to_cart() function was commented out, so I uncommented it so people couldn't use the 'buy now' all the time. This made the 'buy now' show the same error 'you have not won this auction'. Here's what I did so that they could play nice:

Line 1161 of uc_auction.module

'success' => $node->uc_auction['high_bid_uid'] === $user->uid && time() > $node->uc_auction['expiry'],

used to be that, but I changed it to this:

'success' => $node->uc_auction['high_bid_uid'] === $user->uid && time() > $node->uc_auction['expiry'] || $node->uc_auction['buy_now'] == TRUE,

That way if the user has won the auction they can buy OR if it's a BIN auction they can purchase it.

Garrett Albright’s picture

Garrett Albright commented

With regards to the starting price field being disabled; thanks for bringing that to my attention. That is indeed a bug, and it's been squashed. I'll commit the fix to CVS in a moment. I also fixed the problem you found on the user auction lists.

As for the "add to cart" button showing up when not wanted on auctions, I fixed that on Monday-ish. Is the version of Ubercart Auction you're using newer than that?

andrewoke’s picture

andrewoke commented

I don't believe so. I'm going to check out the latest dev release and see what happens.

andrewoke’s picture

andrewoke commented

Ok, tried the jan.20 release.

When 'products are auctions by default' is selected the price field is still disabled.

In uc_auction.user.inc line 40

uc_currency_format($node->sell_price),

needs to be changed to:

uc_currency_format($node->uc_auction['high_bid_amt']),

It's late and I've been tearing this module apart for days. If anything else comes up I'll let you know.

Garrett Albright’s picture

Garrett Albright commented

Yeah, I ended up not committing the changes yesterday like I said I would… sorry.

andrewoke’s picture

andrewoke commented

No problems. My only real problem I had was the 'Add To Cart' showing up. I've got people testing the website for launch right now and they have no idea it's still a dev module. They think it's awesome how the time counts down etc.

So good work. If this site takes off I'm going to make a donation to the project.

Garrett Albright’s picture

Garrett Albright commented

Testing for launch? Holy crap, really? It sounds like your site is closer to launch than the actual site I'm developing this for! I hope it works… Keep in touch.

Also, how do you intend on donating? I don't really have anything set up to receive donations at the moment, plus I'm not sure of the propriety of accepting donations as I'm technically already being paid to develop it. The core Ubercart crew and the Drupal project will be glad to take your money, though.

andrewoke’s picture

andrewoke commented

I'll probably donate to ubercart then as this is the second site I'll be using this on.

The site I'm using this on is daylilyauctions dot com (don't want a link back from here).

Oh yeah, before I forget... is there a place where I can see the diff's between each release? I've modified a bunch of the code (auction table, etc) for the site and just want to check out the changes and apply them.

Garrett Albright’s picture

Garrett Albright commented

You can browse the web-based CVS browser here and see diffs between various versions.

Garrett Albright’s picture

Garrett Albright commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.